public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Fix ice-on-invalid calling get_unwidened (error_mark_node,  ) (PR c++/32567)
Date: Fri, 24 Aug 2007 01:14:00 -0000	[thread overview]
Message-ID: <46CE005B.9040306@codesourcery.com> (raw)
In-Reply-To: <20070821182556.GO2063@devserv.devel.redhat.com>

Jakub Jelinek wrote:

> 2007-08-21  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR c++/32567
> 	* typeck.c (build_unary_op) <case PREINCREMENT_EXPR>: Return
> 	error_mark_node right away if build_expr_type_conversion
> 	returned it.

This is OK.

FWIW, I'd actually do it the opposite way of what you suggested.  For
routines that are part of the middle-end API designed to be used by the
front end, accepting error_mark_nodes as inputs means that we don't have
to remember to check as many places in the front ends.  By being
generous in what we accept in the middle end, we'd make the compiler
more robust, at the expense of doing a bit of extra checking.

But, I'm happy to have the bug fixed, and it's not worth arguing about.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

      reply	other threads:[~2007-08-24  1:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-21 18:53 Jakub Jelinek
2007-08-24  1:14 ` Mark Mitchell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46CE005B.9040306@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).