public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kazu Hirata <kazu@codesourcery.com>
To: richard@codesourcery.com
Cc: gcc-patches@gcc.gnu.org,  law@redhat.com,  schwab@suse.de,
	  nathan@codesourcery.com
Subject: Re: [patch] m68k: Don't use a sibcall from an interrupt handler.
Date: Sat, 25 Aug 2007 15:14:00 -0000	[thread overview]
Message-ID: <46D03F58.9010106@codesourcery.com> (raw)
In-Reply-To: <87y7fzq53s.fsf@firetop.home>

Hi Richard,

> Minor nit, but the comment for this function is:
> 
> /* Implement TARGET_FUNCTION_OK_FOR_SIBCALL_P.  We cannot use sibcalls
>    for nested functions because we use the static chain register for
>    indirect calls.  */
> 
> Now that the function is checking for more than nested functions,
> the second sentence seems out of place.  I think you should move it
> above the TREE_OPERAND check instead.  (I'm sure I'm not the only one
> who has no idea what TREE_OPERAND (exp, 2) is testing without that
> comment to explain things.)

Thank you for spotting this.  Upon looking into tree.h, I found 
CALL_EXPR_STATIC_CHAIN.  I'll post a new patch with your comment suggestion 
and use of CALL_EXPR_STATIC_CHAIN incorporated.

Thanks,

Kazu Hirata

      reply	other threads:[~2007-08-25 14:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-24 22:43 Kazu Hirata
2007-08-25 11:09 ` Richard Sandiford
2007-08-25 15:14   ` Kazu Hirata [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D03F58.9010106@codesourcery.com \
    --to=kazu@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    --cc=nathan@codesourcery.com \
    --cc=richard@codesourcery.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).