[v3] libstdc++/33128

[v3] libstdc++/33128

[Paolo Carlini]

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]

Hi,

tested x86_64-linux, committed mainline and 4_2-branch.

Paolo.

//////////////

[-- Attachment #2: CL_33128 --]
[-- Type: text/plain, Size: 242 bytes --]

2007-08-28  Paolo Carlini  <pcarlini@suse.de>

	PR libstdc++/33128
	* include/tr1_impl/random (uniform_int<>::_M_call): Deal with
	__urng() returning negative values.
	* testsuite/tr1/5_numerical_facilities/random/uniform_int/33128.cc:
	New.

[-- Attachment #3: patch_33128 --]
[-- Type: text/plain, Size: 2338 bytes --]

Index: include/tr1_impl/random
===================================================================
--- include/tr1_impl/random	(revision 127829)
+++ include/tr1_impl/random	(working copy)
@@ -1604,7 +1604,11 @@
         result_type
         _M_call(_UniformRandomNumberGenerator& __urng,
 		result_type __min, result_type __max, true_type)
-        { return result_type(__urng() % (__max - __min + 1)) + __min; }
+        {
+	  typename __gnu_cxx::__add_unsigned<typename
+	    _UniformRandomNumberGenerator::result_type>::__type __tmp = __urng();
+	  return result_type(__tmp % (__max - __min + 1)) + __min; 
+	}
 
       template<typename _UniformRandomNumberGenerator>
         result_type
Index: testsuite/tr1/5_numerical_facilities/random/uniform_int/33128.cc
===================================================================
--- testsuite/tr1/5_numerical_facilities/random/uniform_int/33128.cc	(revision 0)
+++ testsuite/tr1/5_numerical_facilities/random/uniform_int/33128.cc	(revision 0)
@@ -0,0 +1,43 @@
+// Copyright (C) 2007 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 2, or (at your option)
+// any later version.
+//
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING.  If not, write to the Free
+// Software Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
+// USA.
+
+// 5.1.7.1 Class template uniform_int
+// 5.1.1 [7] Table 17
+
+#include <tr1/random>
+#include <testsuite_hooks.h>
+
+// libstdc++/33128
+int test01()
+{
+  bool test __attribute__((unused)) = true;
+
+  std::tr1::mt19937 rng;
+  std::tr1::uniform_int<> six(1,6);
+  std::tr1::variate_generator<std::tr1::mt19937, std::tr1::uniform_int<> >
+            die(rng, six);
+
+  int val = die();
+  VERIFY( val >= 1 && val <= 6 );
+}
+
+int main()
+{
+  test01();
+  return 0;
+}