From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0686B38708AC for ; Thu, 21 Dec 2023 19:38:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0686B38708AC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0686B38708AC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703187512; cv=none; b=E76j7zvOawCpe7zDuM/opR/pHNGO3tK/nQSK7IZ2RI6JmpQ8b9v7WPTbRPtuO76eznW8mrQBhslyzUAWLwfeMwThiI0du9VxGZtZFRLFQXF1eqUZKiJyh8wDRVItdRq/X+VTDBu5NEmZWHGB/w5mOI/4/bDnjqotsZL74acbvWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703187512; c=relaxed/simple; bh=zt2rbkNrMdfkBDNJAlSNRKBCoECoWsCtRt+Wq4T18bU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=K4S6mUQ7lPzDBCcI+OXN52lOCu95cTyE0ApywyNkfyUitOu7QoKgFDolaOCSxvoPOY6OP7I7JKUW+PiiMGYCFgWz/i2k1ndiz0+UHZZwxl3TxYP6FAiPD2AAkciVmPUuB8i3Lt5Kzl0yO56m55Z/nxaB6qPCqMgbNAoxCucXvKk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703187510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vU+z7SOmeh49Atebi1T1QOYjKLkDRi7DWw7HGJxacGk=; b=Frs71C1KhrMYz5aQW/CaPfC52FXZWUAJpRKToG+ZuEiuWbduZv6KstCCqRRJ97M7+mMVLQ FF7mi0W1VYWlAON3NI+efnXfTfzDYyDOLBkgpwq/tEaA982HzzjjJLG3FBOOZglgMd2Qs8 8fzNkNLusFSCHK0GVs8C8xaZZEYm0Mw= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-57cLG0KePCWGVlW5ZkI2dA-1; Thu, 21 Dec 2023 14:38:29 -0500 X-MC-Unique: 57cLG0KePCWGVlW5ZkI2dA-1 Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-3ba2072052cso1219006b6e.2 for ; Thu, 21 Dec 2023 11:38:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703187508; x=1703792308; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vU+z7SOmeh49Atebi1T1QOYjKLkDRi7DWw7HGJxacGk=; b=lJR5AdgdOvz1AyRG5pZzP4KuY2sBPcWGi2XaLzS4nH/kVpMttUzBTEwmfLdMpJNKWv DYfiKH7WHlsxYkHcnmVNwTHJt1wWmDZqbcT/kyHoncNeM8b1Zv547fCx4JIIdsqVVczS VAYH3hvD0Sy6Tc9pLdBYL4kmkUqJaEDBqWxPL+fZM5prwuQVcDWiH1vEDoDvd+MmbN9u Yrh3qCqd+NgtfE7CG2kQhwoVJsq9W3tHNJxvyDZXSnPVApHlrGWRMa/lcbihcySqyb90 C0rBXIp+mxXNUKrtvZ4AU04UHLV4pPoCHcubCggEBahte2YIeMP9mjs9+ZTEqkmOGTU2 rpgw== X-Gm-Message-State: AOJu0YyhwlAIVnUEYoNCx3+pflwFBXmThOcwpU9BdPjRgt4Io0vFq2m9 PtCr7eTFlJQmkyoQtqB0w1U+e3YWBBJF16rQv56VEbSpeJ9b/bZ2CXVv8Nvrt2m3By+oVWYWPsJ OlXOiWFdoeRwMGbYPDzRxN/1zzFsF6SJTkg== X-Received: by 2002:a05:6808:3a0e:b0:3b9:f8eb:21ee with SMTP id gr14-20020a0568083a0e00b003b9f8eb21eemr248605oib.104.1703187507945; Thu, 21 Dec 2023 11:38:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjv/0MA97z9UhYtkQmwLdJXi2Kbxf51yEPRrPNgBrAc5gneCwb+YaQiDUuc68byI4DuvOSig== X-Received: by 2002:a05:6808:3a0e:b0:3b9:f8eb:21ee with SMTP id gr14-20020a0568083a0e00b003b9f8eb21eemr248595oib.104.1703187507723; Thu, 21 Dec 2023 11:38:27 -0800 (PST) Received: from [192.168.1.146] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id v5-20020a0ced45000000b0067f40a725c3sm840157qvq.33.2023.12.21.11.38.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 11:38:27 -0800 (PST) Message-ID: <46d932c7-fc47-4e9b-8bbe-dc46a865bf1e@redhat.com> Date: Thu, 21 Dec 2023 14:38:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] testsuite: Remove testsuite_tr1.h To: Patrick Palka , Ken Matsui Cc: gcc-patches@gcc.gnu.org References: <20231220190824.399818-1-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/21/23 10:52, Patrick Palka wrote: > On Thu, Dec 21, 2023 at 8:29 AM Patrick Palka wrote: >> >> On Wed, 20 Dec 2023, Ken Matsui wrote: >> >>> This patch removes the testsuite_tr1.h dependency from g++.dg/ext/is_*.C >>> tests since the header is supposed to be used only by libstdc++, not >>> front-end. This also includes test code consistency fixes. > > For the record this fixes the test failures reported at > https://gcc.gnu.org/pipermail/gcc-patches/2023-December/641058.html > >> >> LGTM > > Very minor but let's use the commit title > > c++: testsuite: Remove testsuite_tr1.h includes > > to convey that the commit only touches C++ tests, and isn't removing > the file testsuite_tr1.h but rather #includes of it :) OK with that change. Jason