From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 932103858C41 for ; Fri, 9 Jun 2023 14:46:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 932103858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1b24eba184bso6998825ad.0 for ; Fri, 09 Jun 2023 07:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686321960; x=1688913960; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PnYHqEF4fDwHjOH4J56UXFoDiWsMRmkyzvkdSZOlXxo=; b=Kco7kmTVl4QbHlsURRG+737H0cTtE3P+T3cJepub++ovN8HxMZIrSlpcMoepQBc1Uv HvQOBJqJL92Hi5XcykivYHb+qd+CG8EVXTNSUxNq9mSiksDJdOe1uR2L0L8WOr0kDmrQ EnVRdbsluy7duq3OGuxa9dKENtQvslxleXDKWVK7THn9f/scAODbUfHPKJyL4Wd8Lgem 7aPX/gTqDzakB9uFSLLUQ4+n6hEYQyryvml+2RVh3G/+s2mbr60izTKv3OUzkjKbkoyK 9GlvJNb1Bw6SosYYvNZhwUHgz/JpIV1uObxco8EoIiUExz0nQEI+YiHl83m4uxZ3D16r 24Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686321960; x=1688913960; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PnYHqEF4fDwHjOH4J56UXFoDiWsMRmkyzvkdSZOlXxo=; b=Be1rfu8xUiL15hfFL8Ha9sLDWWpJAkJGMNsv8FDJbR33E4pmmF9m0qf2iIoxxr3ev9 DV9meXqmk9UGiS/Ooo9Hx0kgwycr+IA3AuHuPnC2kOSnScXrDcHwGBdSPSFxXOSGEGlU 2V9fWRByOAmS7PZi29C+4yUAHqhp9m3Eb/45eneSn90WJuo/cgkz71rKdjZzzrUJJ5as NTlVR5QzGodWrNTnjA5nhAsC0e69HlPILaDHEM7D2fazb3ZcoLE+vfiO5WZKHNoAYuH9 8UY4e0YdjM67mFajt57y+l0JfWPfNheqzEvKllGUrB/kdpDVy2hw8f4/MYMj06NAd+n/ UdhA== X-Gm-Message-State: AC+VfDwpicMXOGQmohVTaaC//f3KlVwKxzo+NiEpH0A0D7UjXQTrS+1C mL8wpdz7Y0If1fM8jvi4JdM= X-Google-Smtp-Source: ACHHUZ4KcVXY/itoIXQRs3gtnXFAVo+K/BP/ANjjIwSa0Gsn71A6SN81vTOVVTXdBjE5JlXuq9vWXA== X-Received: by 2002:a17:902:cecb:b0:1b0:3b07:705b with SMTP id d11-20020a170902cecb00b001b03b07705bmr1243154plg.7.1686321960356; Fri, 09 Jun 2023 07:46:00 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id jk14-20020a170903330e00b001b050df0a93sm3371493plb.93.2023.06.09.07.45.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 07:45:59 -0700 (PDT) Message-ID: <46dfb8a6-a58a-cd1e-ef6f-03f9ddadafaf@gmail.com> Date: Fri, 9 Jun 2023 08:45:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement Content-Language: en-US To: Robin Dapp , juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org Cc: kito.cheng@sifive.com, palmer@rivosinc.com References: <20230609143241.115366-1-juzhe.zhong@rivai.ai> <445cc0e3-68ba-f2ef-79b1-e0c2ff64f39d@gmail.com> From: Jeff Law In-Reply-To: <445cc0e3-68ba-f2ef-79b1-e0c2ff64f39d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/9/23 08:37, Robin Dapp wrote: > On 6/9/23 16:32, juzhe.zhong@rivai.ai wrote: >> From: Juzhe-Zhong >> >> This patch fixes the requirement of V_WHOLE and V_FRACT. >> E.g. VNx8QI in V_WHOLE has no requirement which is incorrect. >> Actually, VNx8QI should be whole(full) mode when TARGET_MIN_VLEN < 128 >> since when TARGET_MIN_VLEN == 128, VNx8QI is e8mf2 which is fractional >> vector. >> >> gcc/ChangeLog: >> >> * config/riscv/vector-iterators.md: Fix requirement. > > I actually have the attached already on my local tree (as well as a test), > and wanted to post it with the vec_set patch. I think the alignment helps > a bit with readability. > > From 147a459dfbf1fe9d5dd93148f475f42dee3bd94b Mon Sep 17 00:00:00 2001 > From: Robin Dapp > Date: Tue, 6 Jun 2023 17:29:26 +0200 > Subject: [PATCH] RISC-V: Change V_WHOLE iterator to properly match > instruction. > > Currently we emit e.g. an vl1r.v even when loading a mode whose size is > smaller than the hardware vector size. This can happen when reload > decides to switch to another alternative. > > This patch fixes the iterator and adds a testcase for the problem. > > gcc/ChangeLog: > > * config/riscv/vector-iterators.md: Add guards for modes smaller > than the hardware vector size. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/autovec/vls-vlmax/full-vec-move1.c: New test. Sounds like Juzhe is OK with this moving independently. So I'll rubber stamp it. :-) jeff