From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62985 invoked by alias); 16 Jun 2017 16:37:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 62970 invoked by uid 89); 16 Jun 2017 16:37:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Jun 2017 16:37:19 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 3FA8281489; Fri, 16 Jun 2017 18:37:22 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s2QEQaBOElWV; Fri, 16 Jun 2017 18:37:22 +0200 (CEST) Received: from [IPv6:2a02:2ab8:224:1:f21f:afff:fe4c:b838] (cacatoes.act-europe.fr [IPv6:2a02:2ab8:224:1:f21f:afff:fe4c:b838]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 2185F8147E; Fri, 16 Jun 2017 18:37:22 +0200 (CEST) Subject: Re: [PATCH] [PR79542][Ada] Fix ICE in dwarf2out.c with nested func. inlining From: Pierre-Marie de Rodat To: Jason Merrill Cc: gcc-patches List References: <20170314122410.21497-1-derodat@adacore.com> Message-ID: <46eecd7f-8c54-515d-c3cb-f3806c6da61c@adacore.com> Date: Fri, 16 Jun 2017 16:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01216.txt.bz2 On 05/26/2017 04:12 PM, Pierre-Marie de Rodat wrote: > I tried this, but I got a crash when compiling the Ada runtime > (g-awk.adb). I could not extract a reproducer, but the idea is that > because of the call to set_decl_origin_self, some DECLs have themselves > as DECL_ABSTRACT_ORIGIN. As a result, my patch in modified_type_die does > not prevent execution from calling gen_typedef_die with a DECL that has > a non-null abstract origin. So I have to soften the assertion so that > this specific case was still allowed in gen_typedef_die. > > So here’s the update patch: bootstrapped and regtested fine on > x86_64-linux. Ping for the updated patch, originally submitted at https://gcc.gnu.org/ml/gcc-patches/2017-05/msg02049.html Thanks! -- Pierre-Marie de Rodat