[v3] libstdc++/33487

[v3] libstdc++/33487

[Benjamin Kosnik]

This fixes up some issues when calling parallel functions.

One issue was with includes: some <algorithm> functions used bits of
<numerics> without an include. Fixed with the include.

As part of this, __gnu_sequential injections were moved to tags.h, and
all of std::__norm in parallel mode was injected into __gnu_sequential
when in parallel mode. This cleans up things nicely.

The major change here is to make sure that there is a parallel mode
function that exactly matches the iso signature. Before, some of the
parallel functions had a compatible signature with an extra argument
(with a default). This was problematic due to the tags being declared
in __gnu_parallel.

tested x86/linux
tested x86/linux parallel

-benjamin

Re: [v3] libstdc++/33487

[bkoz]

[-- Attachment #1: Type: text/plain, Size: 36 bytes --]

Ooops. Here's the patch.

-benjamin

[-- Attachment #2: p.20071006-1.bz2 --]
[-- Type: application/x-bzip2, Size: 17411 bytes --]

Re: [v3] libstdc++/33487

[Bernardo Innocenti]

bkoz wrote:
> Ooops. Here's the patch.

Could we please avoid sending patches as compressed attachments?

The ability to quickly see the code in your MUA and easily quote
it in replies is important for reviewers.  Certainly more important
than a minor bandwidth saving.

Just attaching uncompressed files is not enough: it still makes it
very difficult to quote the text in replies.  The only work-around
I've found for it is:

 - save the attachment to a file
 - create a new mail
 - insert the file in the body of the mail
 - send the mail to self
 - wait for it to come back
 - start a reply
 - copy all the quoted text in the clipboard
 - throw away the reply
 - start a reply to the original mail
 - paste the clipboard into it
 - begin reviewing...

A little inconvenient, isn't it? :-)

-- 
 \___/
 |___|   Bernardo Innocenti - http://www.codewiz.org/
  \___\  One Laptop Per Child - http://www.laptop.org/

Re: [v3] libstdc++/33487

[Andreas Schwab]

Bernardo Innocenti <bernie@codewiz.org> writes:

> Just attaching uncompressed files is not enough: it still makes it
> very difficult to quote the text in replies.

Does it?  I think it is a bug in your MUA if it cannot quote from
attachments.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [v3] libstdc++/33487

[Bernardo Innocenti]

On 10/07/2007 04:25 AM, Andreas Schwab wrote:
> Bernardo Innocenti <bernie@codewiz.org> writes:
> 
>> Just attaching uncompressed files is not enough: it still makes it
>> very difficult to quote the text in replies.
> 
> Does it?  I think it is a bug in your MUA if it cannot quote from
> attachments.

Certainly not a "bug".  A missing exotic feature, maybe.
Thunderbird, Evolution and KMail don't seem to support it.

And quoting gzipped attachments would be an even more
surprising feature.  If your MUA also has decent support
for IMAP and multiple folders, it's a sale :-)

-- 
 \___/
 |___|  Bernardo Innocenti - http://www.codewiz.org/
  \___\ One Laptop Per Child - http://www.laptop.org/

Re: [v3] libstdc++/33487

[Andreas Schwab]

Bernardo Innocenti <bernie@codewiz.org> writes:

> On 10/07/2007 04:25 AM, Andreas Schwab wrote:
>> Bernardo Innocenti <bernie@codewiz.org> writes:
>>
>>> Just attaching uncompressed files is not enough: it still makes it
>>> very difficult to quote the text in replies.
>>
>> Does it?  I think it is a bug in your MUA if it cannot quote from
>> attachments.
>
> Certainly not a "bug".  A missing exotic feature, maybe.

Not very exotic, in my book.  After all, it's just a part of the same
message.

> Thunderbird, Evolution and KMail don't seem to support it.

That's what you get from using inferior tools. :-)

> And quoting gzipped attachments would be an even more
> surprising feature.  If your MUA also has decent support
> for IMAP and multiple folders, it's a sale :-)

Never used IMAP myself, but the other features work like a charm.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [v3] libstdc++/33487

[Bernardo Innocenti]

On 10/07/2007 06:15 AM, Andreas Schwab wrote:


>> Thunderbird, Evolution and KMail don't seem to support it.
> 
> That's what you get from using inferior tools. :-)

Hmpf... the usual Emacs user attitude of looking down on
everybody else for using a different... OS!

Ok, we're now super OT and dangerously on the edge of yet
another thermonuclear flame war on editors.  Let's follow
up on alt.religion.emacs :-)

Sarcasm apart, the bottom line is: if Gnus is the only MUA
capable of comfortably handling patches as attachments, then
it's not fair to do so.  What was the problem we were trying
to address by not sending the patches inline?

PS: I've been looking to replacing Thunderbird for some
time now.  I've recently discarded Mutt because I couldn't
get it to play nice with 3GB of mail in 80 IMAP folders.
I'll give a second look at Gnus and see if I can get used
to it.

-- 
 \___/
 |___|   Bernardo Innocenti - http://www.codewiz.org/
  \___\  One Laptop Per Child - http://www.laptop.org/

Re: [v3] libstdc++/33487

[Andrew Pinski]

On 10/7/07, Bernardo Innocenti <bernie@codewiz.org> wrote:
> On 10/07/2007 06:15 AM, Andreas Schwab wrote:
>
>
> >> Thunderbird, Evolution and KMail don't seem to support it.
> >
> > That's what you get from using inferior tools. :-)
>
> Hmpf... the usual Emacs user attitude of looking down on
> everybody else for using a different... OS!

elm supports this feature; plus I don't like emacs anyways, vi ftw.

--Pinski