From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 63E1E3858D1E for ; Sun, 12 Jun 2022 18:09:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63E1E3858D1E Received: by mail-pf1-x42b.google.com with SMTP id u2so3930288pfc.2 for ; Sun, 12 Jun 2022 11:09:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=80x37HuOXOgVZJ5ezpWMiMRUvhcDJsv8SWlrXpgmv+Q=; b=jf879YqxZeoXkRVuECBqczgQ2TuXzeyJUYh9r6ao7YXBvP26aHQu+u8x25uQTusb7l 1o13lBQ9ql7rkcC9yTkwmUK1R9NAi1T6aQnYdMF7455TMowp3bGEN/vbwejUwLAPSufU oGfgg43e+1/1d3h+gVuTsYSkx2C7Apg9wbwn3NeBBSZ09TpY1qp1zU82JwNHIjEozg0S exo606EAFUEsVjlh6qfF/CEXcHeYGKfTyJxny5YRBR2qFSYG3JNYPLq9GHjHrzoDH2zk Pwi8OfSL7Cs+aZjd2ZlYWnBkKTbx/jr5ez7J70J9d+rTOBpiRjZvzOAI1Vas9sMjqFCe LRkA== X-Gm-Message-State: AOAM530MT/N91CnztwUGg3OFqAQLEVE0cgv5I88DSVwbPBpSrPTx98Xu dn8+JMNqeToGGZCoZSyvWtpJzbN7wVf5uQ== X-Google-Smtp-Source: ABdhPJyV2Av2CtUyZHqdc35IU55yH9fAI7DhZAFlp5HQYp5P5D1QZYpfAvljSlY5h9JlyfNcPD/SyA== X-Received: by 2002:a63:b13:0:b0:3fd:f319:f6aa with SMTP id 19-20020a630b13000000b003fdf319f6aamr26773089pgl.483.1655057343091; Sun, 12 Jun 2022 11:09:03 -0700 (PDT) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id iy13-20020a170903130d00b00163cdf1a200sm3371938plb.38.2022.06.12.11.09.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jun 2022 11:09:02 -0700 (PDT) Message-ID: <4708f986-c910-9eb9-d475-c9256f59666c@gmail.com> Date: Sun, 12 Jun 2022 12:09:01 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 2/2] Add a general mapping from internal fns to target insns Content-Language: en-US To: gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jun 2022 18:09:08 -0000 On 6/10/2022 3:14 AM, Richard Sandiford via Gcc-patches wrote: > Several existing internal functions map directly to an instruction > defined in target-insns.def. This patch makes it easier to define > more such functions in future. > > This should help to reduce cut-&-paste, but more importantly, it allows > the difference between optab functions and target-insns.def functions > to be abstracted away; both are now treated as “directly-mapped”. > > Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? > > Richard > > > gcc/ > * internal-fn.def (DEF_INTERNAL_INSN_FN): New macro. > (GOMP_SIMT_ENTER_ALLOC, GOMP_SIMT_EXIT, GOMP_SIMT_LANE) > (GOMP_SIMT_LAST_LANE, GOMP_SIMT_ORDERED_PRED, GOMP_SIMT_VOTE_ANY) > (GOMP_SIMT_XCHG_BFLY, GOMP_SIMT_XCHG_IDX): Use it. > * internal-fn.h (direct_internal_fn_info::directly_mapped): New > member variable. > (direct_internal_fn_info::vectorizable): Reduce to 1 bit. > (direct_internal_fn_p): Also return true for internal functions > that map directly to instructions defined target-insns.def. > (direct_internal_fn): Adjust comment accordingly. > * internal-fn.c (direct_insn, optab1, optab2, vectorizable_optab1) > (vectorizable_optab2): New local macros. > (not_direct): Initialize directly_mapped. > (mask_load_direct, load_lanes_direct, mask_load_lanes_direct) > (gather_load_direct, len_load_direct, mask_store_direct) > (store_lanes_direct, mask_store_lanes_direct, vec_cond_mask_direct) > (vec_cond_direct, scatter_store_direct, len_store_direct) > (vec_set_direct, unary_direct, binary_direct, ternary_direct) > (cond_unary_direct, cond_binary_direct, cond_ternary_direct) > (while_direct, fold_extract_direct, fold_left_direct) > (mask_fold_left_direct, check_ptrs_direct): Use the macros above. > (expand_GOMP_SIMT_ENTER_ALLOC, expand_GOMP_SIMT_EXIT): Delete > (expand_GOMP_SIMT_LANE, expand_GOMP_SIMT_LAST_LANE): Likewise; > (expand_GOMP_SIMT_ORDERED_PRED, expand_GOMP_SIMT_VOTE_ANY): Likewise. > (expand_GOMP_SIMT_XCHG_BFLY, expand_GOMP_SIMT_XCHG_IDX): Likewise. > (direct_internal_fn_types): Handle functions that map to instructions > defined in target-insns.def. > (direct_internal_fn_types): Likewise. > (direct_internal_fn_supported_p): Likewise. > (internal_fn_expanders): Likewise. OK. jeff