public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Cc: Gerald Pfeifer <gerald@pfeifer.com>,
	  Diego Novillo <dnovillo@google.com>,
	 GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: enumerate explicitly what is enabled by Wall
Date: Tue, 09 Oct 2007 19:36:00 -0000	[thread overview]
Message-ID: <470BD810.2090908@codesourcery.com> (raw)
In-Reply-To: <6c33472e0710090838j8ccece8k40913dd21365f651@mail.gmail.com>

Manuel López-Ibáñez wrote:
> On 08/10/2007, Mark Mitchell <mark@codesourcery.com> wrote:
>> Gerald Pfeifer wrote:
>>
>>>> 2007-09-30  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
>>>>
>>>>  * c-opts.c(c_common_handle_option): -Wnontemplate-friend,
>>>> -Wwrite-strings and -Wmultichar are enabled by default, so Wall
>>>> enabling them is redundant. Don't check two times for c_dialect_cxx.
>>> This looks more like a bug fix, really.  Mark?
>> Please send me a URL for the full patch, and I shall review.
>>
> 
> The patch is inlined here:
> http://gcc.gnu.org/ml/gcc-patches/2007-09/msg02104.html

This patch is OK.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

      reply	other threads:[~2007-10-09 19:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-23 14:53 Manuel López-Ibáñez
2007-09-29 22:55 ` Manuel López-Ibáñez
2007-09-30 11:27   ` Diego Novillo
2007-09-30 16:13     ` Gerald Pfeifer
2007-09-30 22:16       ` Manuel López-Ibáñez
2007-10-08  0:13         ` Gerald Pfeifer
2007-10-08 22:29           ` Mark Mitchell
2007-10-09 15:39             ` Manuel López-Ibáñez
2007-10-09 19:36               ` Mark Mitchell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470BD810.2090908@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=dnovillo@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gerald@pfeifer.com \
    --cc=lopezibanez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).