From: Mark Mitchell <mark@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Andreas Schwab <schwab@suse.de>, gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Only allow __label__ at the beginning of compound statements as documented (PR c++/32121)
Date: Thu, 11 Oct 2007 04:00:00 -0000 [thread overview]
Message-ID: <470D9FD3.2050503@codesourcery.com> (raw)
In-Reply-To: <20070927153357.GT2625@devserv.devel.redhat.com>
Jakub Jelinek wrote:
> So do I need to write:
>
> /* Parse a compound-statement.
>
> compound-statement:
> { statement-seq [opt] }
>
> GNU extension:
>
> compound-statement:
> { label-declaration-seq [opt] statement-seq [opt] }
>
> label-declaration-seq:
> label-declaration
> label-declaration-seq label-declaration
>
> Returns a tree representing the statement. */
Yes.
And the patch is OK with that change. I'm sympathetic to Tom's idea
that the beginning-of-block restriction is artificial, and I'm concerned
about backwards-compatibility -- but as this feature exists primarily
for compatibility with GNU C and as I'm not at all confident we handle
the difficult middle-of-block cases correctly, I think this is OK.
However, if reports come in of this causing problems, we will need to
reconsider.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
next prev parent reply other threads:[~2007-10-11 4:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 15:34 Jakub Jelinek
2007-09-27 15:50 ` Andreas Schwab
2007-09-27 16:22 ` Jakub Jelinek
2007-10-11 4:00 ` Mark Mitchell [this message]
2007-09-28 17:45 ` Tom Tromey
2007-09-28 17:49 ` Jakub Jelinek
2007-09-28 22:02 ` Tom Tromey
2007-09-28 22:39 ` Chris Lattner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470D9FD3.2050503@codesourcery.com \
--to=mark@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).