public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [SPARC] Fix PR target/105292
@ 2022-05-10  7:49 Eric Botcazou
  0 siblings, 0 replies; only message in thread
From: Eric Botcazou @ 2022-05-10  7:49 UTC (permalink / raw)
  To: gcc-patches

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

This is a regression present since the 10.x series, but the underlying issue 
has been there since the TARGET_VEC_PERM_CONST hook was implemented, in the 
form of an ICE when expanding a constant VEC_PERM_EXPR in V4QI, while the 
back-end only supports V8QI constant VEC_PERM_EXPRs.

Tested on SPARC/Solaris, applied to all active branches.


2022-05-10  Eric Botcazou  <ebotcazou@adacore.com>

	PR target/105292
	* config/sparc/sparc.cc (sparc_vectorize_vec_perm_const): Return
	true only for 8-byte vector modes.


2022-05-10  Eric Botcazou  <ebotcazou@adacore.com>

	* gcc.target/sparc/20220510-1.c: New test.

-- 
Eric Botcazou

[-- Attachment #2: pr105292.diff --]
[-- Type: text/x-patch, Size: 621 bytes --]

diff --git a/gcc/config/sparc/sparc.cc b/gcc/config/sparc/sparc.cc
index 467a9f171d2..aca925befe1 100644
--- a/gcc/config/sparc/sparc.cc
+++ b/gcc/config/sparc/sparc.cc
@@ -13041,9 +13041,9 @@ sparc_vectorize_vec_perm_const (machine_mode vmode, rtx target, rtx op0,
   if (!TARGET_VIS2)
     return false;
 
-  /* All permutes are supported.  */
+  /* All 8-byte permutes are supported.  */
   if (!target)
-    return true;
+    return GET_MODE_SIZE (vmode) == 8;
 
   /* Force target-independent code to convert constant permutations on other
      modes down to V8QI.  Rely on this to avoid the complexity of the byte

[-- Attachment #3: 20220510-1.c --]
[-- Type: text/x-csrc, Size: 633 bytes --]

/* PR target/105292 */
/* Reported by Koakuma <koachan+gccbugs@protonmail.com> */

/* { dg-do compile } */
/* { dg-options "-O3 -mvis2" } */

extern void get_vbytes_v2 (unsigned);

typedef struct {
  unsigned ctt_info;
  unsigned ctt_size;
} ctf_type_t;

typedef struct {
  unsigned short cts_offset;
  unsigned short cts_bits;
} ctf_slice_t;

void flip_types_len (ctf_type_t *t, int bsx1, int bsx2)
{
  const int kind = t->ctt_info;

  get_vbytes_v2 (t->ctt_size);

  if (kind == 4)
    {
      ctf_slice_t *s = (ctf_slice_t *)t;
      s->cts_offset = __builtin_bswap16(bsx1);
      s->cts_bits   = __builtin_bswap16(bsx2);
    }
}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-10  7:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10  7:49 [SPARC] Fix PR target/105292 Eric Botcazou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).