From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2066.outbound.protection.outlook.com [40.107.101.66]) by sourceware.org (Postfix) with ESMTPS id 04F613858D1E for ; Wed, 4 Jan 2023 04:47:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04F613858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NwTnYJhtw6lrzde5KDauTMoeLCU3ZDw4xDpj6mIGNj9wEaAsGw3pTrx8y882QX2pH7OZdNW60vhQL0RrIBQ1PYMCBDrTwq0lU3aN8yYDgmRf2qRf43aHDzcm1+45uPQPnCkXMRwgAKZQI6B4eAVjPT0l8W77jlA/WEHqdkFKWEXtUafHp+2/P4KOp6d4IfHddDt5f/R6s1Y2cYdRQ5V2YxdmflKEiufZtHO+cBXdfuV/owmZQoJBqf2renPChpdVEZ2b87A+d5XTWfJ7V0NLETHWq6xbr0HX03MCA5Me7TpK0vVhm4+661hfHFO8gnQ29nM3V8IeshLYTfOw2muVRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X8maducYIVbTYMQX3VKY7PML0qWgCASfZEtNjIyoU0c=; b=Dyz3XZ968UZ2GI97Wd92hjuWmf4A+pLBJrO4xhoKLldtB+XlWLxJrkOO3nAzKczBHuWlII/rYn4dk/1PPp5Ug+VvAgvEsS+F8Yhjfzg7j3YXKGtIJqDM/ns38POAcVu744q99GIZIDN5LXjp8JyIa9UqwYPK0uctqKnts+1P4RqH82z5qGfIq0Nc0g8KAuvqnAEvKVgB9Ue2JF556KQj5QVDYwNqWPnzDQNt7HIKS8919kJhHAiSsoksLqjbsNAu8pWLWP2aRubBwnq/bBoXpTiXjDDlVX1b3cBsVUTyF9eQXlI/Vk6A5NZBLZy4c1pb0azmWD+udXP6p3XTJHk2Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X8maducYIVbTYMQX3VKY7PML0qWgCASfZEtNjIyoU0c=; b=c/bqHuvjTxU1IvzsuzDQy4bNQCBpptFZdxOrTziomMfyVaoqPK2QwxwtdlxwMRQGaduyK1Pb71b8+P9V5csU1Dyi2OOw51QCiiwm9dVRg16TMM1hIzGZwQDx+Z+HZd2yozKuHqlFbc2ETEXcLe3QcS5FT7sLPT6B9pp5hIa0U8KYJCATATDdn8Vzs7GPVwlOK+0EQUWo1SiAkElkv1ANNl4w+pg2cwb7DHNefc+zyl93qWBVrff4zTIp/ASYw7mQlf/hjFvdsX3RaIUdEw0y8aTyCJuLunTIBcBAOdC5C9X73lTl6HxtmY11gz2S41o9hcmpxj3broWIi+6RdztYPw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from CH2PR07MB7222.namprd07.prod.outlook.com (2603:10b6:610:ab::21) by BYAPR07MB5464.namprd07.prod.outlook.com (2603:10b6:a03:97::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan 2023 04:47:05 +0000 Received: from CH2PR07MB7222.namprd07.prod.outlook.com ([fe80::d452:230e:f9f6:75c4]) by CH2PR07MB7222.namprd07.prod.outlook.com ([fe80::d452:230e:f9f6:75c4%9]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023 04:47:05 +0000 Message-ID: <47206b92-dc53-dc81-16ca-38cae5baee6f@siemens.com> Date: Tue, 3 Jan 2023 21:47:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] [OpenMP] GC unused SIMD clones To: Tobias Burnus , Sandra Loosemore , "gcc-patches@gcc.gnu.org" Cc: Jakub Jelinek References: Content-Language: en-US From: Sandra Loosemore In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CY5PR22CA0107.namprd22.prod.outlook.com (2603:10b6:930:65::17) To CH2PR07MB7222.namprd07.prod.outlook.com (2603:10b6:610:ab::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR07MB7222:EE_|BYAPR07MB5464:EE_ X-MS-Office365-Filtering-Correlation-Id: 5cb5fe8f-a6cf-4cea-1bda-08daee0eba7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cAOknNh3JSZsZ3HtGc7OQRnzaor49EO8XH1lfAGqUoQYeXFpwi09x8JoOSZifKB/bCH9V/hlCE7EEZz+/uJ09W6+Md3JWFEB4M6sBcYwmUpYCDJrS4e2sw8h0SoAJPB1Ae15bcDr/1fXe8slTjSZl/TVbMTjoIpciLsWkqQoZoc8Mx2fokHkd8M+7BJS8PaGwnRTTxgT3k/SCdyRCZKT4VavjyuxdKLi0JD2ugITYTKd/j80KGJMtfgoL4JJE1dZ3WTlC659njxaU/tEtCE55Elcvq7BYRc12YPQUHaQJ//vi6A2W2zrFriClJpX0D08nJPdKff/POx6Husr1rLX3JoSRTl3IDa6POaEw22M6kUb41/87OM/lKUERZ7DM9rB76AntP2tP/+p84R6fp63BReMU4f/N51LTf0vnLGahZ893H7pQ2m95cZ3igaBCajlGZsMR2BDkLk6G+eVuDc3iP0qKD6y4BDkmxmLxmq0Sak9OKYpKOsD4NjMuCIXy+haTxEPUJ1M7Gbbej7HXhQ7e475+p3HAm75HuObMntnXU31Ea2HbjjdnWbk4wYDDzcpA0AtHj/a8yaqXiRWvXkPbIOtwUGhG5/0OLsj3xuhgBaFK/9hIrraVJ+4L5zLf+NL+dFU7pUgrNgHxZnt561rURhd2fwtXGd33/a/IY1YVm2uH60BW9vrX9ZvW3BHRJ/2oD4ibq3vUsxusYi4pD5RCByA6boa5wUbjmbUqK6EfdxWLMUXgTXs/OXDvd0gINWJ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR07MB7222.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199015)(83380400001)(2616005)(31696002)(86362001)(82960400001)(316002)(38100700002)(36756003)(44832011)(31686004)(2906002)(66946007)(8936002)(110136005)(4326008)(41300700001)(66556008)(8676002)(5660300002)(66476007)(26005)(53546011)(186003)(6512007)(6486002)(966005)(478600001)(6666004)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHhvUmlZd2ppTUJxVWgxQXAwUms5K0FaZmV4TURnZHdJZFBMWTQ3TWdhck5S?= =?utf-8?B?eG9ERG4vcWkxNitiVEVsZmlBRzgxYUlNdTc3RXFQODBGd3NRejFnNm4wQ2c0?= =?utf-8?B?MldyMHI0TTJnb0NYSjhiUm1JV2xHTXBEeExOajVuNWJlK2hPbGV3Y1Bkcis3?= =?utf-8?B?MFR6UkJORWw2NWkzQ2ZHNU9xN0ZIVlVOTGhyOFRtWjBOODFkS0ZsdnVoWXp2?= =?utf-8?B?M3lXajBzSC9vcStUWm5oUDM0aG1NcXRjQWJ4b2EyRE94bW5vQlNTMWF5N3Ba?= =?utf-8?B?Mklqa2F5Uy8vdks4d2Z4RGxQMFVmTlB4M2hkM1UvNEVwUTgybVAvZGUyMlF4?= =?utf-8?B?dVN3dVpKOHp5ck5UdVBUSkNyZm5GUW9YYUt3MGJ3Rnoyb1lnSnlSN2lRTGZv?= =?utf-8?B?M0pqMzJLMzVwd2lkTVVPRTB5aCtHVTdFZ25lVlU1L2F6eWQyeUIwWGtRRnVt?= =?utf-8?B?R3RFR2t2OEQ1Wms0d1ZCUWJGcUNRWFpVcDdYVjRteFdxMlBwdFpaZUtqOEVR?= =?utf-8?B?cXFmNVlJK215VjhWOHY3QWpZM0lPc1VlbEJBYmNwaThBR1dpejJsSXhDeUpX?= =?utf-8?B?NWJING14NDJlc2p2emtRQ2pFTFJyb0w4NE5zNm0zb3FtVnRnMkxuZ2VVaUVr?= =?utf-8?B?SEIzQi9iT1luczJFREgrMzhwd2RJdkxSYnZUclhrUWFtakxhdE9RbW4zZGdm?= =?utf-8?B?NDhBR0Y1bFJ3Z0UvaEhjL0o0RTRIQWtUUjBPdUhGWER3OERzSURMNmRXOFlU?= =?utf-8?B?MEg3SGErOHNoR1FuakM3SGRiR1RucGNvaHNtNXRkdVdZWENGRThPS1kwQ0Fk?= =?utf-8?B?U2dTTS9WRW9sdjNQeFkzREtKVTQrZWF3Y0RlZG50QkpEMyt5MHd3clFZZ1JX?= =?utf-8?B?UFo0cjR4eHNnYlRUbngvdklZYnQzS0hIZHA1Yi9wTFNXNzc1cEVrRmhiR1Jr?= =?utf-8?B?dUZWRlk2T2FkaHphYk9CWWJyWGI5cEpVbGxZVThNSnY0ZjZqcnk5Q3dUSk5B?= =?utf-8?B?V2tHZmQ0RXhEd3V0UVFrYmtuaE03WlZKWDBIUlhuMi9KamIvd2ZDL3dueHF2?= =?utf-8?B?VHl5alkwTHJ5WCt2cU9URDBsakg4anJ6Y2locExjQkVuUlVHUEtUT243dTQ0?= =?utf-8?B?eXNueXZZYVhjRVBqUUFpM0RGZVBMSzRoRU9ZTmhOb24zT2QrMTI4N1BrbmdR?= =?utf-8?B?NE9oZkx0aEFXQ1dZL2NUa2MyazF0dTBNOGYxZ2ZYUWkwV3pUeWh0YTJpa0JX?= =?utf-8?B?R3VaNk90aExsMmtxdTN6MzlwUVpNU3pkRXJQeVRNelJpc1ROSjdId1ZaYkdH?= =?utf-8?B?VlQ2N1F2NkdPeFdYbWJIR3pwQXlDU3RLYzFBTXNLeVdiREYyK1ZrTzU4QXR0?= =?utf-8?B?a2k2bzJtWURSUkNMR2xqdWRsUTJIYng0RVA4M2MwVnNYTStZWkw0RDlubXRq?= =?utf-8?B?VWpoQ3pDelRmMkhUREZVRDZYNVFLUzl2Z0pNOWVtaTJ4aXJhdlBudDdKK2tJ?= =?utf-8?B?NXNpSlR6QUxmb0RseTNnUHcxbFBkRGZZaXJ2Q09paHFORWRMNUlZQjNidEh5?= =?utf-8?B?STNySlhXaUNBL2pDOGlqRW9DVzBQNGFGZzEzV3U4M05lKzVOVXI5RWVXTmtP?= =?utf-8?B?TXRuMFJJcEJ5NDZTZEVzOTlvbU56UXByT3kxd1NuT1UySTRXRUVvdGc3R2ZJ?= =?utf-8?B?cTNiam11Q0RNQk5Mb2V4a3JtY1ZlUXJja0grUVhmNW9RSUtTSnZQc1VUcWtT?= =?utf-8?B?MWRyaU9DcXF5MDQ0aDRidXpqeGlNWFFxQzhIazZEczd5MDZDTUUzelA5cThh?= =?utf-8?B?OEs1ZmM5djdRYXdOVDNRUzM4NEJrdjB1T2JnT3A2SnlMUlh4K3dUMHU5SnF5?= =?utf-8?B?dlhCc09iUjhKaXYwY1U1S3dUZitUS24yeHN2MjFaRnpIWVFsMU01UjJ3U1Rp?= =?utf-8?B?TURrTzFjV1ZKZzdkTUROY1dxZjRNdWt2MHBNcmpySlQ0NXNWTnRrcWV2eW5S?= =?utf-8?B?Z2FWNXY3ZmNUVDUxYmV4L0FURWZnMHN5U21YQ3BsUkw1VWxKZWNxWUNZdGVE?= =?utf-8?B?Qm9Ua0tXYlk4M0Vwblk5b3l4cVJUanhnV3lqMkRuL3B6azBjbExwQ0FrK2xO?= =?utf-8?B?cWVqUmJuUHpjVzJrc2NhUkpTb2wwZy8wYzJHRjNqWjVTQmdvaFNXZ21leXpr?= =?utf-8?B?V0E9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cb5fe8f-a6cf-4cea-1bda-08daee0eba7e X-MS-Exchange-CrossTenant-AuthSource: CH2PR07MB7222.namprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 04:47:05.5094 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HrIEL4iGDsSGaRNxNzuo0s9hHDNwg8VMsSR2VYfVnkCivlUGEj+xApJt0V5OlxpETfKM2nnSEkNcbr5YhH7P7dK7soj/W8itjDsHfD9ucKA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5464 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/2/23 03:20, Tobias Burnus wrote: > On 25.11.22 03:13, Sandra Loosemore wrote: >> This patch is a followup to my not-yet-reviewed patch >> [PATCH v4] OpenMP: Generate SIMD clones for functions with "declare >> target" > > That patch got reviewed and went into mainline on Nov 15, 2022 as > https://gcc.gnu.org/r13-4309-g309e2d95e3b930c6f15c8a5346b913158404c76d>> > >> In comments on a previous iteration of that patch, I was asked to do >> something to delete unused SIMD clones to avoid code bloat; this is it. >> >> I've implemented something like a simple mark-and-sweep algorithm. >> Clones that are used are marked at the point where the call is >> generated in the vectorizer.  The loop that iterates over functions to >> apply the passes after IPA is modified to defer processing of unmarked >> clones, and anything left over is deleted. > > > Jakub referred to Honza for the review, who wrote yesterday off list (to > me and Sandra): > >> I am really sorry for taking so long time.  It was busy month for me >> and I was not very keen about the idea, since we had such logic >> implemented many years ago but removed it to be able to determine >> functions to be output early and optimize code layout. >> >> I see that this is not possible with current organization where >> vectorization is run late, so I guess it does make sense to do what you >> are doing. >> >> Patch is OK, >> Honza > > Thanks for the review! (And to Sandra: thanks for the patch.) > > I leave it to Sandra to commit her patch and only want to update the > gcc-patches@ email. However. I think we can expect a commit tomorrow. > (Today is a holiday at her place - as new year's day fell on a Sunday.) Yes, the patch is committed now, and also backported to og12. Thanks, Honza, for the review, and Tobias, for your assistance. I'm really glad to get this project done, finally. :-) -Sandra