public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, testsuite]: Update g++.dg/tree-ssa/ivopts-1.C
@ 2007-10-26 11:20 Uros Bizjak
  2007-10-27 12:47 ` Uros Bizjak
  0 siblings, 1 reply; 2+ messages in thread
From: Uros Bizjak @ 2007-10-26 11:20 UTC (permalink / raw)
  To: GCC Patches

Hello!

Currently, ivopts-1.C tests with:

XPASS: g++.dg/tree-ssa/ivopts-1.C scan-tree-dump-not offset: -4B
XPASS: g++.dg/tree-ssa/ivopts-1.C scan-tree-dump-not &x\\[5\\]

According to the testresult logs, second XPASS can be removed, as the
test now passes on i686-*-*-*, x86_64-*-*-* and hppa*-*-*-*.

The cause for the second XPASS is described in PR 26726, comment #15:

--cut here--
 ------- Comment #15 From Andrew Pinski  2007-06-04 05:36  [reply] -------

One should note that:
/* { dg-final { scan-tree-dump-not "offset: -4B" "ivopts" { xfail i?86-*-*
x86_64-*-* } } } */

Will not match any more since switching over offset to sizetype.
--cut here--

Attached patch updates scanning pattern to "offset: 0x0f+fc", so we
match 0x0f...fc pattern that covers 32, 64 and possible 16bit targets.

2007-10-26  Uros Bizjak  <ubizjak@gmail.com>

	* g++.dg/tree-ssa/ivopts-1.C: Remove xfail on the search for
	"&x\\\[5\\\]" pattern.  Search for "offset: 0x0f+fc" instead of
	"offset: -4B".

The patch was tested on i686-pc-linux-gnu, committed to SVN.

Uros.

Index: g++.dg/tree-ssa/ivopts-1.C
===================================================================
--- g++.dg/tree-ssa/ivopts-1.C  (revision 129643)
+++ g++.dg/tree-ssa/ivopts-1.C  (working copy)
@@ -13,6 +13,6 @@
 }

 /* { dg-final { scan-tree-dump-not "-&x" "ivopts" } } */
-/* { dg-final { scan-tree-dump-not "offset: -4B" "ivopts" { xfail
i?86-*-* x86_64-*-* hppa*-*-* } } } */
-/* { dg-final { scan-tree-dump-not "&x\\\[5\\\]" "ivopts" { xfail
i?86-*-* x86_64-*-* hppa*-*-* } } } */
+/* { dg-final { scan-tree-dump-not "offset: 0x0f+fc" "ivopts" { xfail
i?86-*-* x86_64-*-* hppa*-*-* } } } */
+/* { dg-final { scan-tree-dump-not "&x\\\[5\\\]" "ivopts" } } */
 /* { dg-final { cleanup-tree-dump "ivopts" } } */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, testsuite]: Update g++.dg/tree-ssa/ivopts-1.C
  2007-10-26 11:20 [PATCH, testsuite]: Update g++.dg/tree-ssa/ivopts-1.C Uros Bizjak
@ 2007-10-27 12:47 ` Uros Bizjak
  0 siblings, 0 replies; 2+ messages in thread
From: Uros Bizjak @ 2007-10-27 12:47 UTC (permalink / raw)
  To: Uros Bizjak; +Cc: GCC Patches

Hello!

> Attached patch updates scanning pattern to "offset: 0x0f+fc", so we
> match 0x0f...fc pattern that covers 32, 64 and possible 16bit targets.
>   

Additionally, we have to search for "offset: 4294967292" in case value 
fits HWI of 64bit. This happens on x86_64 host when testing with -m32.

Attached update was tested on x86_64-pc-linux-gnu with and without -m32. 
Patch is committed to SVN.

2007-10-27  Uros Bizjak  <ubizjak@gmail.com>

        * g++.dg/tree-ssa/ivopts-1.C: Also search for "offset: 4294967292".

Uros.

Index: g++.dg/tree-ssa/ivopts-1.C
===================================================================
--- g++.dg/tree-ssa/ivopts-1.C  (revision 129674)
+++ g++.dg/tree-ssa/ivopts-1.C  (working copy)
@@ -13,6 +13,6 @@
 }
 
 /* { dg-final { scan-tree-dump-not "-&x" "ivopts" } } */
-/* { dg-final { scan-tree-dump-not "offset: 0x0f+fc" "ivopts" { xfail 
i?86-*-* x86_64-*-* hppa*-*-* } } } */
+/* { dg-final { scan-tree-dump-not "offset: (4294967292|0x0f+fc)" 
"ivopts" { xfail i?86-*-* x86_64-*-* hppa*-*-* } } } */
 /* { dg-final { scan-tree-dump-not "&x\\\[5\\\]" "ivopts" } } */
 /* { dg-final { cleanup-tree-dump "ivopts" } } */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-10-27 11:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-26 11:20 [PATCH, testsuite]: Update g++.dg/tree-ssa/ivopts-1.C Uros Bizjak
2007-10-27 12:47 ` Uros Bizjak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).