From: Xinyu Qi <xyqi@marvell.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH, ARM, iWMMXT] PR target/54338 - Include IWMMXT_GR_REGS in ALL_REGS
Date: Tue, 02 Apr 2013 09:55:00 -0000 [thread overview]
Message-ID: <4737A960563B524DA805CA602BE04B3069CB36D7C7@SC-VEXCH2.marvell.com> (raw)
In-Reply-To: <CAJA7tRZkbWrPNZ0269T4caEs=Aez7eNfaH1OU5dNuKvQh=G8JQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
Hi,
According to Vladimir Makarov's analysis, the root cause of PR target/54338 is that ALL_REGS doesn't contain IWMMXT_GR_REGS in REG_CLASS_CONTENTS.
It seems there is no reason to exclude the IWMMXT_GR_REGS from ALL_REGS as IWMMXT_GR_REGS are the real registers.
This patch simply makes ALL_REGS include IWMMXT_GR_REGS to fix this PR.
Since the test case gcc.target/arm/mmx-2.c would fail for the same reason and become pass with this fix, no extra test case need to be add.
Pass arm.exp test. Patch attached.
ChangeLog
2013-04-02 Xinyu Qi <xyqi@marvell.com>
* config/arm/arm.h (REG_CLASS_CONTENTS): Include IWMMXT_GR_REGS in ALL_REGS.
OK?
Thanks,
Xinyu
[-- Attachment #2: IWMMXT_GR_REGS.diff --]
[-- Type: application/octet-stream, Size: 1359 bytes --]
Index: config/arm/arm.h
===================================================================
*** config/arm/arm.h (revision 197340)
--- config/arm/arm.h (working copy)
***************
*** 1203,1213 ****
{ 0x00000000, 0x00000000, 0x00000000, 0x0000000F }, /* IWMMXT_GR_REGS */ \
{ 0x00000000, 0x00000000, 0x00000000, 0x00000010 }, /* CC_REG */ \
{ 0x00000000, 0x00000000, 0x00000000, 0x00000020 }, /* VFPCC_REG */ \
{ 0x00000000, 0x00000000, 0x00000000, 0x00000040 }, /* SFP_REG */ \
{ 0x00000000, 0x00000000, 0x00000000, 0x00000080 }, /* AFP_REG */ \
! { 0xFFFF7FFF, 0xFFFFFFFF, 0xFFFFFFFF, 0x00000000 } /* ALL_REGS */ \
}
/* Any of the VFP register classes. */
#define IS_VFP_CLASS(X) \
((X) == VFP_D0_D7_REGS || (X) == VFP_LO_REGS \
--- 1203,1213 ----
{ 0x00000000, 0x00000000, 0x00000000, 0x0000000F }, /* IWMMXT_GR_REGS */ \
{ 0x00000000, 0x00000000, 0x00000000, 0x00000010 }, /* CC_REG */ \
{ 0x00000000, 0x00000000, 0x00000000, 0x00000020 }, /* VFPCC_REG */ \
{ 0x00000000, 0x00000000, 0x00000000, 0x00000040 }, /* SFP_REG */ \
{ 0x00000000, 0x00000000, 0x00000000, 0x00000080 }, /* AFP_REG */ \
! { 0xFFFF7FFF, 0xFFFFFFFF, 0xFFFFFFFF, 0x0000000F } /* ALL_REGS */ \
}
/* Any of the VFP register classes. */
#define IS_VFP_CLASS(X) \
((X) == VFP_D0_D7_REGS || (X) == VFP_LO_REGS \
next prev parent reply other threads:[~2013-04-02 9:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 4:13 [PATCH ARM iWMMXt 0/5] Improve iWMMXt support Matt Turner
2012-05-29 4:14 ` [PATCH ARM iWMMXt 5/5] pipeline description Matt Turner
2012-05-29 4:14 ` [PATCH ARM iWMMXt 1/5] ARM code generic change Matt Turner
2012-06-06 11:53 ` Ramana Radhakrishnan
2012-12-27 2:31 ` [PATCH, ARM, iWMMXT] Fix define_constants for WCGR Xinyu Qi
2013-01-22 9:22 ` [PING][PATCH, " Xinyu Qi
2013-01-22 11:59 ` Ramana Radhakrishnan
2013-01-22 13:34 ` Andreas Schwab
2013-01-23 6:08 ` Xinyu Qi
2013-01-31 8:49 ` [PATCH, " Xinyu Qi
2013-03-20 2:43 ` Xinyu Qi
2013-03-26 14:01 ` Ramana Radhakrishnan
2013-04-02 9:55 ` Xinyu Qi [this message]
2013-04-02 10:03 ` [PATCH, ARM, iWMMXT] PR target/54338 - Include IWMMXT_GR_REGS in ALL_REGS Ramana Radhakrishnan
2012-05-29 4:14 ` [PATCH ARM iWMMXt 3/5] built in define and expand Matt Turner
2012-06-06 11:55 ` Ramana Radhakrishnan
2012-05-29 4:15 ` [PATCH ARM iWMMXt 2/5] intrinsic head file change Matt Turner
2012-06-06 12:22 ` Ramana Radhakrishnan
2012-05-29 4:15 ` [PATCH ARM iWMMXt 4/5] WMMX machine description Matt Turner
2012-06-06 11:59 ` [PATCH ARM iWMMXt 0/5] Improve iWMMXt support Ramana Radhakrishnan
2012-06-11 9:24 ` nick clifton
2012-06-13 7:36 ` nick clifton
2012-06-13 15:31 ` Matt Turner
2012-06-26 15:20 ` nick clifton
2012-06-27 19:15 ` Matt Turner
2013-01-28 3:49 ` Matt Turner
2013-01-28 15:11 ` nick clifton
2013-02-21 2:35 ` closing PR's (was Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support) Hans-Peter Nilsson
2013-02-22 12:42 ` nick clifton
2013-04-08 8:43 [PATCH, ARM, iWMMXT] PR target/54338 - Include IWMMXT_GR_REGS in ALL_REGS Xinyu Qi
2013-04-08 13:25 ` Ramana Radhakrishnan
2013-04-30 13:59 ` Matthew Gretton-Dann
2013-05-02 1:21 ` Xinyu Qi
2013-05-14 22:40 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4737A960563B524DA805CA602BE04B3069CB36D7C7@SC-VEXCH2.marvell.com \
--to=xyqi@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).