public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Don't emit diagnostic about redefined extern inline always_inline  functions (PR tree-optimization/33763)
Date: Mon, 12 Nov 2007 01:47:00 -0000	[thread overview]
Message-ID: <4737A99D.2090108@codesourcery.com> (raw)
In-Reply-To: <20071106154224.GI5451@devserv.devel.redhat.com>

Jakub Jelinek wrote:

> No GCC so far has been able to inline extern inline functions when they
> are redefined, because that means have two different bodies for a function,
> one for the out of line copy and one for inlining. 

> But we never actually documented what happens if you redefine extern
> always_inline inline function.  Older GCCs silently didn't inline it,
> 4.[123] issue diagnostic and fail.

I think 4.x is doing the right thing.  The always_inline attribute means
that the function should always be inlined, and the compiler isn't
inlining the function, so issuing the error makes sense.  The idea with
always_inline extern inline functions is that all calls are inlined; the
only time you get the out-of-line version of the function is if you take
its address.

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

      reply	other threads:[~2007-11-12  1:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-06 15:47 Jakub Jelinek
2007-11-12  1:47 ` Mark Mitchell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4737A99D.2090108@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).