From: Diego Novillo <dnovillo@google.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Fix PR 33870
Date: Wed, 14 Nov 2007 14:09:00 -0000 [thread overview]
Message-ID: <473AF069.7010101@google.com> (raw)
In-Reply-To: <84fc9c000711140446l74fc9b36l4bfc2f024a21a66f@mail.gmail.com>
Richard Guenther wrote:
> I guess in add_uids_for_ptset instead of
>
> ! if (SFT_NESTING_LEVEL (sft) > 0)
> ! SFT_UNPARTITIONABLE_P (sft) = true;
>
> we can get away with only doing that if the type of the SFT itself could
> have subvariables (which is probably again what you intended?).
Hmm, well the SFTs themselves are usually of scalar type. The first SFT
of an int[] array is of type int. Yes, the bug is around here. Perhaps
the easiest way to fix this is to mark the variable earlier when we are
pushing fields in the fieldstack (in the code that computes the nesting
level). And then transport that marker into the SFT here.
Diego.
next prev parent reply other threads:[~2007-11-14 12:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 0:24 Diego Novillo
2007-11-08 0:35 ` Jakub Jelinek
2007-11-08 2:20 ` Diego Novillo
2007-11-08 10:45 ` Richard Guenther
2007-11-13 16:30 ` Diego Novillo
2007-11-13 16:47 ` Richard Guenther
2007-11-14 12:36 ` Richard Guenther
2007-11-14 12:41 ` Richard Guenther
2007-11-14 13:01 ` Diego Novillo
2007-11-14 13:18 ` Richard Guenther
2007-11-14 13:59 ` Diego Novillo
2007-11-14 14:07 ` Richard Guenther
2007-11-14 14:09 ` Diego Novillo [this message]
2007-11-14 14:22 ` Richard Guenther
2007-11-14 15:29 ` Richard Guenther
2007-11-14 15:30 ` Diego Novillo
2007-11-15 13:55 ` Richard Guenther
2007-11-15 15:47 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473AF069.7010101@google.com \
--to=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).