From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5519 invoked by alias); 10 Feb 2017 17:25:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5500 invoked by uid 89); 10 Feb 2017 17:25:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1255, H*i:sk:589DF05, H*MI:sk:589DF05, H*f:sk:589DF05 X-HELO: sasl.smtp.pobox.com Received: from pb-smtp1.pobox.com (HELO sasl.smtp.pobox.com) (64.147.108.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Feb 2017 17:24:53 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D642C67C0A; Fri, 10 Feb 2017 12:24:51 -0500 (EST) Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id CD0FF67C09; Fri, 10 Feb 2017 12:24:51 -0500 (EST) Received: from [192.168.1.4] (unknown [76.215.41.237]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id E602D67C06; Fri, 10 Feb 2017 12:24:50 -0500 (EST) Subject: Re: [PATCH 2/8] [i386] Add option -moutline-msabi-xlogues To: Sandra Loosemore , Bernhard Reutner-Fischer , gcc-patches@gcc.gnu.org, Uros Bizjak , Jan Hubicka , JonY <10walls@gmail.com> References: <2fd14fe7-8d06-45ab-fb1e-96c9c8f4c03b@pobox.com> <20170207184023.19155-2-daniel.santos@pobox.com> <38614916-f4a6-d7db-5ab0-97f1587de170@pobox.com> <589DF051.1090003@codesourcery.com> From: Daniel Santos Message-ID: <4742e468-b5ae-b11b-0500-45064894f550@pobox.com> Date: Fri, 10 Feb 2017 17:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <589DF051.1090003@codesourcery.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: D46EA5CA-EFB5-11E6-8AC8-FE3F13518317-06139138!pb-smtp1.pobox.com X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00729.txt.bz2 On 02/10/2017 10:54 AM, Sandra Loosemore wrote: > On 02/09/2017 09:46 PM, Daniel Santos wrote: >> On 02/08/2017 05:28 PM, Bernhard Reutner-Fischer wrote: >>> On 7 February 2017 19:40:17 CET, Daniel Santos >>> wrote: >>> >>>> + { "-mmoutline-msabi-xlogues", MASK_OUTLINE_MSABI_XLOGUES } >>>> }; >>> s/mm/m/ > > I'd like to re-iterate my previous request that the option be renamed > -mno-inline-msabi-xlogues. No other option that controls inlining > uses "outline" for the negative (disabling inlining). We have way too > many options and the least we can do is try to make them use > consistent conventions. > > -Sandra Thank you. I was just mentioning that and I agree, I just thought I should get feedback from i386 guys. I did quote you in the main email on this issue: > For now, I have called this feature -moutline-msabi-xlogues, but > Sandra Loosemore has this suggestion: > (https://gcc.gnu.org/ml/gcc-patches/2016-11/msg02670.html) > >> Just as a suggestion (I'm not an i386 maintainer), I'd recommend >> spelling the name of this option -mno-inline-msabi-xlogues instead of >> -moutline-msabi-xlogues, and making the default -minline-msabi-xlogues. Daniel