From: Paolo Bonzini <bonzini@gnu.org>
To: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,
Hans-Peter Nilsson <hp@bitrange.com>,
Thiemo Seufer <ths@networkno.de>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Don't hardcode the makefile name in config-ml.in
Date: Mon, 26 Nov 2007 14:17:00 -0000 [thread overview]
Message-ID: <474AA476.7020605@gnu.org> (raw)
In-Reply-To: <20071126092650.GA15889@ins.uni-bonn.de>
> Please try the first patch in
> <http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01183.html>.
The third patch there is okay.
Now on to the first. First of all, my apologies for approving the wrong
patch. I hadn't realized that the modified code was inside a "cat << \EOF".
If I understand correctly, the ${Makefile} in
for dir in ${Makefile} $(MULTIDIRS); do \
is just a way to avoid an error if MULTIDIRS is empty but [ -z
"$(MULTIDIRS)" ] does not get it? If this is the case, I would prefer
to have something like
set fnord $(MULTIDIRS); shift; \
lib=`${PWD_COMMAND} | sed -e 's,^.*/\([^/][^/]*\)$$,\1,'`; \
for dir; do \
EOF
cat >>Multi.tem <<EOF
if [ -f ../$${dir}/$${lib}/${Makefile} ]; then \
EOF
cat >>Multi.tem <<\EOF
if (cd ../$${dir}/$${lib}; $(MAKE) $(FLAGS_TO_PASS) $(DO)); \
then true; \
else exit 1; \
fi; \
else true; \
fi; \
done; \
Ralf, portability-wise, what do you think?
Paolo
next prev parent reply other threads:[~2007-11-26 10:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 10:24 Thiemo Seufer
2007-11-19 10:49 ` Paolo Bonzini
2007-11-26 6:44 ` Hans-Peter Nilsson
2007-11-26 10:48 ` Ralf Wildenhues
2007-11-26 14:17 ` Paolo Bonzini [this message]
2007-11-26 14:47 ` Andreas Schwab
2007-11-26 15:04 ` Ralf Wildenhues
2007-11-26 15:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474AA476.7020605@gnu.org \
--to=bonzini@gnu.org \
--cc=Ralf.Wildenhues@gmx.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).