Re: RFA: Improve 128-bit long double configure test

[Mark Mitchell <mark@codesourcery.com>]

Daniel Jacobowitz wrote:
> On Fri, Nov 23, 2007 at 05:52:43PM -0800, Mark Mitchell wrote:
>> Assuming that we don't want to move away from probing here, I have a
>> couple of questions about your patch.  It looks like we've got
>> target-probing code for __stack_chk_fail right aboe the code you changed
>> that does the same kind of search for GLIBC headers.  I'd expect that
>> your change should be applied to that code too, or, better, that the
>> code that finds GLIBC headers should be factored out.
> 
> It was - that's why there were two pieces of the patch.

Sorry, I must have missed that.  I apologize.

>> Also, why wouldn't your method (using CPP) going to work on all
>> host/target combinations?  If so, we should use it everywhere,
>> rather than just in the ($host = $target) != $build case.
> 
> It relies on the compiler being GCC; I don't know if I can get away
> with that for any other compiler one might use to build a
> Linux-targeted GCC.

That makes sense.  Personally, I'd be happy to stop trying to support
building GCC with non-GCC compilers, but I understand that's certain to
be controversial and I'm not advocating it.

I would like to hear from the Power maintainers, though, about whether
we can just remove this attempt at auto-probing the target altogether,
though.  I'd rather make people building the compiler work pass an
explicit configuration option and simplify this logic.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713