public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: Kenneth Zadeck <zadeck@naturalbridge.com>
Cc: "Andrew Pinski" <pinskia@gmail.com>,
	"\"Doug Kwan (關振德)\"" <dougkwan@google.com>,
	gcc-patches@gcc.gnu.org, "Diego Novillo" <dnovillo@google.com>,
	"Nathan Froyd" <froydnj@codesourcery.com>
Subject: Re: [LTO][PATCH] Fix long double precision problem
Date: Wed, 05 Dec 2007 16:34:00 -0000	[thread overview]
Message-ID: <4756D2FB.6020703@codesourcery.com> (raw)
In-Reply-To: <47569FA0.5040308@naturalbridge.com>

Kenneth Zadeck wrote:

>> I think for ia64-hpux, you can use both TFmode and XFmode so maybe
>> this is not going to work for that.
>>
>> --Pinski
>>   
> is the right solution to just serialize the size and restore it from that?

Yes, and that's what the current code is doing; it looks at
DW_AT_bit_size in the DWARF information to determine how many bits to
use.  If that's not sufficient because, for example, DW_AT_bit_size is
the number of bits consumed in memory, but TYPE_PRECISION is supposed to
be the number of bits of useful data, then we should add a
DW_AT_gnu_precision attribute to the DWARF.

This is exactly the kind of DWARF extension we want to make: in addition
to being useful for LTO, we get better information for the debugger.
Please make sure that any new DWARF attributes are clearly documented,
without reference to GCC internals; the right documentation for
DW_AT_gnu_precision is not "this is TYPE_PRECISION".

However, first we should check if DW_AT_bit_size is being emitted correctly.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

  parent reply	other threads:[~2007-12-05 16:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-05  7:05 Doug Kwan (關振德)
2007-12-05 10:52 ` Andrew Pinski
2007-12-05 12:55   ` Kenneth Zadeck
2007-12-05 14:56     ` Diego Novillo
2007-12-05 16:28       ` Doug Kwan (關振德)
2007-12-05 19:02         ` Andrew Pinski
2007-12-05 16:34     ` Mark Mitchell [this message]
2007-12-05 18:42       ` Doug Kwan (關振德)
2007-12-05 19:01       ` Doug Kwan (關振德)
2007-12-05 23:52         ` Mark Mitchell
2007-12-11 23:15           ` Doug Kwan (關振德)
2007-12-12  9:22             ` Mark Mitchell
2007-12-12 20:23               ` Doug Kwan (關振德)
2007-12-12 20:45                 ` Mark Mitchell
2007-12-13  2:27                   ` Doug Kwan (關振德)
2007-12-13 11:02                     ` Andreas Schwab
2007-12-13 19:13                       ` Doug Kwan (關振德)
2007-12-14  9:50                         ` Andreas Schwab
2007-12-14 22:18                           ` Doug Kwan (關振德)
2007-12-13 20:11                   ` Jim Blandy
2007-12-13 20:40                     ` Doug Kwan (關振德)
2007-12-13 22:43                       ` Jim Blandy
     [not found]                         ` <4765FBC0.8020400@codesourcery.com>
2007-12-17 21:53                           ` Doug Kwan (關振德)
2007-12-18  4:29                             ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4756D2FB.6020703@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=dnovillo@google.com \
    --cc=dougkwan@google.com \
    --cc=froydnj@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pinskia@gmail.com \
    --cc=zadeck@naturalbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).