public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: "\"Doug Kwan (關振德)\"" <dougkwan@google.com>
Cc: Kenneth Zadeck <zadeck@naturalbridge.com>,
	  Andrew Pinski <pinskia@gmail.com>,
	 gcc-patches@gcc.gnu.org, Diego Novillo <dnovillo@google.com>,
	  Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [LTO][PATCH] Fix long double precision problem
Date: Wed, 05 Dec 2007 23:52:00 -0000	[thread overview]
Message-ID: <475739AD.5050705@codesourcery.com> (raw)
In-Reply-To: <498552560712051100s283acdc3le82c21759d7c3b6f@mail.gmail.com>

Doug Kwan (關振德) wrote:
> The reason why I did the patch that way is to avoid changing the
> external debugging interface. If we need to serialize precisions, we
> may not need another GNU dwarf extension.  Currently already gcc emits
> DW_AT_bit_size and DW_AT_bit_offset pairs for integral types whose
> precisions are less than their bit width.  We can just add code to
> handling real scalar types.

Yes, I think you're 100% right.  I've reviewed the DWARF spec and,
indeed, DW_AT_bit_size/DW_AT_bit_offset are designed for exactly this
case.  So, we should just arrange to emit that information in dwarf2out.c.

> I am not sure what changes, if any, are required on the client side of
> the debugging information (e.g. gdb).  I am willing to implement those
> changes though.

I'm certainly not a GDB expert so I don't know what impact that might
have either.  It's just making the debug information more complete, so,
hopefully, it should Just Work, but it could of course also be the case
that something goes wrong.  Running the GDB testsuite is probably a good
first cut.  I'd suggest asking on the GDB mailing list.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

  reply	other threads:[~2007-12-05 23:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-05  7:05 Doug Kwan (關振德)
2007-12-05 10:52 ` Andrew Pinski
2007-12-05 12:55   ` Kenneth Zadeck
2007-12-05 14:56     ` Diego Novillo
2007-12-05 16:28       ` Doug Kwan (關振德)
2007-12-05 19:02         ` Andrew Pinski
2007-12-05 16:34     ` Mark Mitchell
2007-12-05 18:42       ` Doug Kwan (關振德)
2007-12-05 19:01       ` Doug Kwan (關振德)
2007-12-05 23:52         ` Mark Mitchell [this message]
2007-12-11 23:15           ` Doug Kwan (關振德)
2007-12-12  9:22             ` Mark Mitchell
2007-12-12 20:23               ` Doug Kwan (關振德)
2007-12-12 20:45                 ` Mark Mitchell
2007-12-13  2:27                   ` Doug Kwan (關振德)
2007-12-13 11:02                     ` Andreas Schwab
2007-12-13 19:13                       ` Doug Kwan (關振德)
2007-12-14  9:50                         ` Andreas Schwab
2007-12-14 22:18                           ` Doug Kwan (關振德)
2007-12-13 20:11                   ` Jim Blandy
2007-12-13 20:40                     ` Doug Kwan (關振德)
2007-12-13 22:43                       ` Jim Blandy
     [not found]                         ` <4765FBC0.8020400@codesourcery.com>
2007-12-17 21:53                           ` Doug Kwan (關振德)
2007-12-18  4:29                             ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475739AD.5050705@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=dnovillo@google.com \
    --cc=dougkwan@google.com \
    --cc=froydnj@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pinskia@gmail.com \
    --cc=zadeck@naturalbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).