From: Mark Mitchell <mark@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Fix -frepo (PR c++/34178, c++/34340, take 3)
Date: Sat, 08 Dec 2007 01:27:00 -0000 [thread overview]
Message-ID: <4759F30C.90603@codesourcery.com> (raw)
In-Reply-To: <20071207225143.GK13207@devserv.devel.redhat.com>
Jakub Jelinek wrote:
> That seems to work too, for make check-g++ at least (but there are just
> very few -frepo testcases, which is probably why this could be broken for so
> long).
> PR c++/34178
> PR c++/34340
> * repo.c (repo_emit_p): Return 2 for DECL_INTEGRAL_CONSTANT_VAR_P
> in class scope rather than DECL_INITIALIZED_BY_CONSTANT_EXPRESSION_P.
> Return 2 also if DECL_EXPLICIT_INSTANTIATION.
> * decl2.c (import_export_decl): Don't make VAR_DECLs import_p when
> flag_use_repository and repo_emit_p returned 2.
>
> * g++.dg/template/repo6.C: New test.
> * g++.dg/template/repo7.C: New test.
> * g++.dg/template/repo8.C: New test.
If Jason doesn't object within 24 hours, please go ahead and put this
in. This seems sensible (at least to me!) so I think it's worth a try.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713
prev parent reply other threads:[~2007-12-08 1:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 22:30 [C++ PATCH] Fix -frepo (PR c++/34178) Jakub Jelinek
2007-12-05 15:14 ` [C++ PATCH] Fix -frepo (PR c++/34178, take 2) Jakub Jelinek
2007-12-06 1:03 ` Mark Mitchell
2007-12-06 10:48 ` Jakub Jelinek
2007-12-07 4:28 ` Mark Mitchell
2007-12-07 10:35 ` [C++ PATCH] Fix -frepo (PR c++/34178, c++/34340, take 3) Jakub Jelinek
2007-12-07 17:55 ` Mark Mitchell
2007-12-07 22:53 ` Jakub Jelinek
2007-12-08 1:27 ` Mark Mitchell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4759F30C.90603@codesourcery.com \
--to=mark@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).