From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32191 invoked by alias); 8 Dec 2007 01:27:55 -0000 Received: (qmail 32182 invoked by uid 22791); 8 Dec 2007 01:27:55 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Dec 2007 01:27:51 +0000 Received: (qmail 7648 invoked from network); 8 Dec 2007 01:27:49 -0000 Received: from unknown (HELO ?10.210.73.112?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Dec 2007 01:27:49 -0000 Message-ID: <4759F30C.90603@codesourcery.com> Date: Sat, 08 Dec 2007 01:27:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Jakub Jelinek CC: Jason Merrill , gcc-patches@gcc.gnu.org Subject: Re: [C++ PATCH] Fix -frepo (PR c++/34178, c++/34340, take 3) References: <20071127215831.GX16835@devserv.devel.redhat.com> <20071205151120.GA25112@devserv.devel.redhat.com> <47574A61.1060200@codesourcery.com> <20071206104553.GG25112@devserv.devel.redhat.com> <4758CBCB.3030604@codesourcery.com> <20071207103256.GD13207@devserv.devel.redhat.com> <47598920.7090900@codesourcery.com> <20071207225143.GK13207@devserv.devel.redhat.com> In-Reply-To: <20071207225143.GK13207@devserv.devel.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00373.txt.bz2 Jakub Jelinek wrote: > That seems to work too, for make check-g++ at least (but there are just > very few -frepo testcases, which is probably why this could be broken for so > long). > PR c++/34178 > PR c++/34340 > * repo.c (repo_emit_p): Return 2 for DECL_INTEGRAL_CONSTANT_VAR_P > in class scope rather than DECL_INITIALIZED_BY_CONSTANT_EXPRESSION_P. > Return 2 also if DECL_EXPLICIT_INSTANTIATION. > * decl2.c (import_export_decl): Don't make VAR_DECLs import_p when > flag_use_repository and repo_emit_p returned 2. > > * g++.dg/template/repo6.C: New test. > * g++.dg/template/repo7.C: New test. > * g++.dg/template/repo8.C: New test. If Jason doesn't object within 24 hours, please go ahead and put this in. This seems sensible (at least to me!) so I think it's worth a try. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713