From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50743 invoked by alias); 14 Jan 2019 13:56:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 50726 invoked by uid 89); 14 Jan 2019 13:56:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=qid, 2069, H*r:ip*0.0.0.0, maps X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Jan 2019 13:56:26 +0000 Received: from svr-orw-mbx-02.mgc.mentorg.com ([147.34.90.202]) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gj2j3-0005It-1j from ChungLin_Tang@mentor.com ; Mon, 14 Jan 2019 05:56:25 -0800 Received: from [0.0.0.0] (147.34.91.1) by svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 14 Jan 2019 05:56:21 -0800 From: Chung-Lin Tang Subject: Re: [PATCH, OpenACC] Properly handle wait clause with no arguments Reply-To: To: Thomas Schwinge , Chung-Lin Tang CC: , Jakub Jelinek , References: <4f14f976-3677-9f94-2ca7-83f5dc8dd7ae@mentor.com> <87d0rgr99i.fsf@euler.schwinge.homeip.net> Message-ID: <4764ef54-8fac-3d58-094f-e06da439fc4e@mentor.com> Date: Mon, 14 Jan 2019 13:56:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------9D3053C6099FFE2ECD254490" X-SW-Source: 2019-01/txt/msg00775.txt.bz2 --------------9D3053C6099FFE2ECD254490 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 607 Hi Thomas, this version of the wait-clause-with-no-args patch revises the following: (1) The way the Fortran FE parts are implemented, which essentially is your code. (I'll reflect that in the final ChangeLog) (2) Instead of trying to encode ACC_ASYNC_NOVAL into num_waits, I've followed your suggestion to just treat it as a normal async. This means the gcc/omp-expand.c parts in the last patch are discarded. (3) Things in oacc-parallel.c have been mostly adjusted to only handle the wait(ACC_ASYNC_NOVAL) case inside goacc_wait(). Hope this is now okay for trunk when appropriate. Thanks, Chung-Lin --------------9D3053C6099FFE2ECD254490 Content-Type: text/plain; charset="UTF-8"; x-mac-type=0; x-mac-creator=0; name="openacc-wait-clause.v2.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="openacc-wait-clause.v2.patch" Content-length: 5486 SW5kZXg6IGdjYy9jL2MtcGFyc2VyLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gZ2NjL2MvYy1wYXJzZXIuYwkocmV2aXNpb24gMjY3OTEzKQorKysg Z2NjL2MvYy1wYXJzZXIuYwkod29ya2luZyBjb3B5KQpAQCAtMTM0MTAsNyAr MTM0MTAsNyBAQCBjX3BhcnNlcl9vYWNjX2NsYXVzZV90aWxlIChjX3BhcnNl ciAqcGFyc2VyLCB0cmVlCiB9CiAKIC8qIE9wZW5BQ0M6Ci0gICB3YWl0ICgg aW50LWV4cHItbGlzdCApICovCisgICB3YWl0IFsoIGludC1leHByLWxpc3Qg KV0gKi8KIAogc3RhdGljIHRyZWUKIGNfcGFyc2VyX29hY2NfY2xhdXNlX3dh aXQgKGNfcGFyc2VyICpwYXJzZXIsIHRyZWUgbGlzdCkKQEAgLTEzNDE5LDcg KzEzNDE5LDE1IEBAIGNfcGFyc2VyX29hY2NfY2xhdXNlX3dhaXQgKGNfcGFy c2VyICpwYXJzZXIsIHRyZWUKIAogICBpZiAoY19wYXJzZXJfcGVla190b2tl biAocGFyc2VyKS0+dHlwZSA9PSBDUFBfT1BFTl9QQVJFTikKICAgICBsaXN0 ID0gY19wYXJzZXJfb2FjY193YWl0X2xpc3QgKHBhcnNlciwgY2xhdXNlX2xv YywgbGlzdCk7CisgIGVsc2UKKyAgICB7CisgICAgICB0cmVlIGMgPSBidWls ZF9vbXBfY2xhdXNlIChjbGF1c2VfbG9jLCBPTVBfQ0xBVVNFX1dBSVQpOwog CisgICAgICBPTVBfQ0xBVVNFX0RFQ0wgKGMpID0gYnVpbGRfaW50X2NzdCAo aW50ZWdlcl90eXBlX25vZGUsIEdPTVBfQVNZTkNfTk9WQUwpOworICAgICAg T01QX0NMQVVTRV9DSEFJTiAoYykgPSBsaXN0OworICAgICAgbGlzdCA9IGM7 CisgICAgfQorCiAgIHJldHVybiBsaXN0OwogfQogCkluZGV4OiBnY2MvY3Av cGFyc2VyLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZ2NjL2NwL3Bh cnNlci5jCShyZXZpc2lvbiAyNjc5MTMpCisrKyBnY2MvY3AvcGFyc2VyLmMJ KHdvcmtpbmcgY29weSkKQEAgLTMyODE1LDcgKzMyODE1LDcgQEAgY3BfcGFy c2VyX29hY2Nfd2FpdF9saXN0IChjcF9wYXJzZXIgKnBhcnNlciwgbG9jYXQK IH0KIAogLyogT3BlbkFDQzoKLSAgIHdhaXQgKCBpbnQtZXhwci1saXN0ICkg Ki8KKyAgIHdhaXQgWyggaW50LWV4cHItbGlzdCApXSAqLwogCiBzdGF0aWMg dHJlZQogY3BfcGFyc2VyX29hY2NfY2xhdXNlX3dhaXQgKGNwX3BhcnNlciAq cGFyc2VyLCB0cmVlIGxpc3QpCkBAIC0zMjgyMiwxMCArMzI4MjIsMTYgQEAg Y3BfcGFyc2VyX29hY2NfY2xhdXNlX3dhaXQgKGNwX3BhcnNlciAqcGFyc2Vy LCB0cmUKIHsKICAgbG9jYXRpb25fdCBsb2NhdGlvbiA9IGNwX2xleGVyX3Bl ZWtfdG9rZW4gKHBhcnNlci0+bGV4ZXIpLT5sb2NhdGlvbjsKIAotICBpZiAo Y3BfbGV4ZXJfcGVla190b2tlbiAocGFyc2VyLT5sZXhlciktPnR5cGUgIT0g Q1BQX09QRU5fUEFSRU4pCi0gICAgcmV0dXJuIGxpc3Q7CisgIGlmIChjcF9s ZXhlcl9wZWVrX3Rva2VuIChwYXJzZXItPmxleGVyKS0+dHlwZSA9PSBDUFBf T1BFTl9QQVJFTikKKyAgICBsaXN0ID0gY3BfcGFyc2VyX29hY2Nfd2FpdF9s aXN0IChwYXJzZXIsIGxvY2F0aW9uLCBsaXN0KTsKKyAgZWxzZQorICAgIHsK KyAgICAgIHRyZWUgYyA9IGJ1aWxkX29tcF9jbGF1c2UgKGxvY2F0aW9uLCBP TVBfQ0xBVVNFX1dBSVQpOwogCi0gIGxpc3QgPSBjcF9wYXJzZXJfb2FjY193 YWl0X2xpc3QgKHBhcnNlciwgbG9jYXRpb24sIGxpc3QpOworICAgICAgT01Q X0NMQVVTRV9ERUNMIChjKSA9IGJ1aWxkX2ludF9jc3QgKGludGVnZXJfdHlw ZV9ub2RlLCBHT01QX0FTWU5DX05PVkFMKTsKKyAgICAgIE9NUF9DTEFVU0Vf Q0hBSU4gKGMpID0gbGlzdDsKKyAgICAgIGxpc3QgPSBjOworICAgIH0KIAog ICByZXR1cm4gbGlzdDsKIH0KSW5kZXg6IGdjYy9mb3J0cmFuL29wZW5tcC5j Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGdjYy9mb3J0cmFuL29wZW5t cC5jCShyZXZpc2lvbiAyNjc5MTMpCisrKyBnY2MvZm9ydHJhbi9vcGVubXAu Ywkod29ya2luZyBjb3B5KQpAQCAtMTg4NSw3ICsxODg1LDE5IEBAIGdmY19t YXRjaF9vbXBfY2xhdXNlcyAoZ2ZjX29tcF9jbGF1c2VzICoqY3AsIGNvbnN0 CiAJCSAgYnJlYWs7CiAJCX0KIAkgICAgICBlbHNlIGlmIChtID09IE1BVENI X05PKQotCQluZWVkc19zcGFjZSA9IHRydWU7CisJCXsKKwkJICBnZmNfZXhw ciAqZXhwcgorCQkgICAgPSBnZmNfZ2V0X2NvbnN0YW50X2V4cHIgKEJUX0lO VEVHRVIsCisJCQkJCSAgICAgZ2ZjX2RlZmF1bHRfaW50ZWdlcl9raW5kLAor CQkJCQkgICAgICZnZmNfY3VycmVudF9sb2N1cyk7CisJCSAgbXB6X3NldF9z aSAoZXhwci0+dmFsdWUuaW50ZWdlciwgR09NUF9BU1lOQ19OT1ZBTCk7CisJ CSAgZ2ZjX2V4cHJfbGlzdCAqKmV4cHJfbGlzdCA9ICZjLT53YWl0X2xpc3Q7 CisJCSAgd2hpbGUgKCpleHByX2xpc3QpCisJCSAgICBleHByX2xpc3QgPSAm KCpleHByX2xpc3QpLT5uZXh0OworCQkgICpleHByX2xpc3QgPSBnZmNfZ2V0 X2V4cHJfbGlzdCAoKTsKKwkJICAoKmV4cHJfbGlzdCktPmV4cHIgPSBleHBy OworCQkgIG5lZWRzX3NwYWNlID0gdHJ1ZTsKKwkJfQogCSAgICAgIGNvbnRp bnVlOwogCSAgICB9CiAJICBpZiAoKG1hc2sgJiBPTVBfQ0xBVVNFX1dPUktF UikKSW5kZXg6IGxpYmdvbXAvb2FjYy1wYXJhbGxlbC5jCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIGxpYmdvbXAvb2FjYy1wYXJhbGxlbC5jCShyZXZp c2lvbiAyNjc5MTMpCisrKyBsaWJnb21wL29hY2MtcGFyYWxsZWwuYwkod29y a2luZyBjb3B5KQpAQCAtMjA2LDkgKzIwNiw3IEBAIEdPQUNDX3BhcmFsbGVs X2tleWVkIChpbnQgZmxhZ3NfbSwgdm9pZCAoKmZuKSAodm9pCiAJY2FzZSBH T01QX0xBVU5DSF9XQUlUOgogCSAgewogCSAgICB1bnNpZ25lZCBudW1fd2Fp dHMgPSBHT01QX0xBVU5DSF9PUCAodGFnKTsKLQotCSAgICBpZiAobnVtX3dh aXRzKQotCSAgICAgIGdvYWNjX3dhaXQgKGFzeW5jLCBudW1fd2FpdHMsICZh cCk7CisJICAgIGdvYWNjX3dhaXQgKGFzeW5jLCBudW1fd2FpdHMsICZhcCk7 CiAJICAgIGJyZWFrOwogCSAgfQogCkBAIC01MTQsMTMgKzUxMiwyMCBAQCBH T0FDQ19lbnRlcl9leGl0X2RhdGEgKGludCBmbGFnc19tLCBzaXplX3QgbWFw bnVtLAogc3RhdGljIHZvaWQKIGdvYWNjX3dhaXQgKGludCBhc3luYywgaW50 IG51bV93YWl0cywgdmFfbGlzdCAqYXApCiB7Ci0gIHN0cnVjdCBnb2FjY190 aHJlYWQgKnRociA9IGdvYWNjX3RocmVhZCAoKTsKLSAgc3RydWN0IGdvbXBf ZGV2aWNlX2Rlc2NyICphY2NfZGV2ID0gdGhyLT5kZXY7Ci0KICAgd2hpbGUg KG51bV93YWl0cy0tKQogICAgIHsKICAgICAgIGludCBxaWQgPSB2YV9hcmcg KCphcCwgaW50KTsKLSAgICAgIAorCisgICAgICAvKiBXYWl0aW5nIG9uIEFD Q19BU1lOQ19OT1ZBTCBtYXBzIHRvICd3YWl0IGFsbCcuICAqLworICAgICAg aWYgKHFpZCA9PSBhY2NfYXN5bmNfbm92YWwpCisJeworCSAgaWYgKGFzeW5j ID09IGFjY19hc3luY19zeW5jKQorCSAgICBhY2Nfd2FpdF9hbGwgKCk7CisJ ICBlbHNlCisJICAgIGFjY193YWl0X2FsbF9hc3luYyAoYXN5bmMpOworCSAg YnJlYWs7CisJfQorCiAgICAgICBpZiAoYWNjX2FzeW5jX3Rlc3QgKHFpZCkp CiAJY29udGludWU7CiAKQEAgLTUzMSw3ICs1MzYsNyBAQCBnb2FjY193YWl0 IChpbnQgYXN5bmMsIGludCBudW1fd2FpdHMsIHZhX2xpc3QgKmFwKQogCSAg ICBsYXVuY2hpbmcgb24sIHRoZSBxdWV1ZSBpdHNlbGYgd2lsbCBvcmRlciB3 b3JrIGFzCiAJICAgIHJlcXVpcmVkLCBzbyB0aGVyZSdzIG5vIG5lZWQgdG8g d2FpdCBleHBsaWNpdGx5LiAgKi8KICAgICAgIGVsc2UKLQlhY2NfZGV2LT5v cGVuYWNjLmFzeW5jX3dhaXRfYXN5bmNfZnVuYyAocWlkLCBhc3luYyk7CisJ YWNjX3dhaXRfYXN5bmMgKHFpZCwgYXN5bmMpOwogICAgIH0KIH0KIAo= --------------9D3053C6099FFE2ECD254490--