From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5876 invoked by alias); 17 Dec 2007 17:02:44 -0000 Received: (qmail 5865 invoked by uid 22791); 17 Dec 2007 17:02:43 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 17:02:37 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lBHH0XcK012066; Mon, 17 Dec 2007 12:00:33 -0500 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lBHH0WM8000551; Mon, 17 Dec 2007 12:00:32 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by lacrosse.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id lBHH0Tg3000996; Mon, 17 Dec 2007 12:00:30 -0500 Message-ID: <4766AB2D.7020708@redhat.com> Date: Mon, 17 Dec 2007 17:19:00 -0000 From: Jason Merrill User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Jakub Jelinek CC: Mark Mitchell , gcc-patches@gcc.gnu.org Subject: Re: [C++ PATCH] Fix regressions introduced by my PR34094 fix (PR c++/34238, c++/34340) References: <20071126233015.GP16835@devserv.devel.redhat.com> <20071205150141.GN16835@devserv.devel.redhat.com> <4758CC95.5040000@codesourcery.com> <20071207074941.GC13207@devserv.devel.redhat.com> <4759B28F.5090608@codesourcery.com> <20071210131740.GE20451@devserv.devel.redhat.com> In-Reply-To: <20071210131740.GE20451@devserv.devel.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-12/txt/msg00806.txt.bz2 It seems safe to give the error if DECL_SYMBOL_REFERENCED (DECL_ASSEMBLER_NAME) is set, just decl_needed_p is too strong a test. Jason