public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>
To: "Robin Dapp" <rdapp.gcc@gmail.com>,
	 gcc-patches <gcc-patches@gcc.gnu.org>,
	 palmer <palmer@dabbelt.com>,  kito.cheng <kito.cheng@gmail.com>,
	 jeffreyalaw <jeffreyalaw@gmail.com>
Cc: "Robin Dapp" <rdapp.gcc@gmail.com>
Subject: Re: Re: [PATCH] RISC-V: Implement autovec copysign.
Date: Wed, 21 Jun 2023 14:38:50 +0800	[thread overview]
Message-ID: <478DD4F8B199C0FA+202306211438500791847@rivai.ai> (raw)
In-Reply-To: <6d7ab96f-188d-8bdb-0e2e-64845a462f2c@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

LGTM as long as you remove all stuff related to UNSPEC_VNCOPYSIGN

Thanks.


juzhe.zhong@rivai.ai
 
From: Robin Dapp
Date: 2023-06-21 14:36
To: 钟居哲; gcc-patches; palmer; kito.cheng; Jeff Law
CC: rdapp.gcc
Subject: Re: [PATCH] RISC-V: Implement autovec copysign.
> You should remove all "unspec" related of "n" ncopysign including riscv-vector-builtins-bases.cc
> vector.md/ vector-iterators.md 
 
Ah, there was indeed one stray UNSPEC_VNCOPYSIGN in the iterators, thanks.  Any other
comments before I sent V2?
 
Regards
Robin
 

  reply	other threads:[~2023-06-21  6:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 12:47 Robin Dapp
2023-06-20 22:25 ` 钟居哲
2023-06-21  6:36   ` Robin Dapp
2023-06-21  6:38     ` juzhe.zhong [this message]
2023-06-21 12:57       ` [PATCH v2] " Robin Dapp
2023-06-21 14:24         ` 钟居哲
2023-06-24 14:39           ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478DD4F8B199C0FA+202306211438500791847@rivai.ai \
    --to=juzhe.zhong@rivai.ai \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=kito.cheng@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=rdapp.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).