[C++ PATCH]: testsuite PIC fix for has_nothrow* tests

[C++ PATCH]: testsuite PIC fix for has_nothrow* tests

[Paolo Carlini]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi,

see the discussion on the audit trail of c++/26099. I think we can just
go with this simple fix, for 4.3.0 at least.

Ok for mainline?

Paolo.

////////////////

[-- Attachment #2: CL2 --]
[-- Type: text/plain, Size: 275 bytes --]

2008-01-27  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
	    Paolo Carlini  <pcarlini@suse.de>

        * g++.dg/ext/has_nothrow_assign.C: Skip some tests when __PIC__.
        * g++.dg/ext/has_nothrow_constructor.C: Likewise.
        * g++.dg/ext/has_nothrow_copy.C: Likewise.

[-- Attachment #3: p2 --]
[-- Type: text/plain, Size: 1641 bytes --]

Index: g++.dg/ext/has_nothrow_assign.C
===================================================================
--- g++.dg/ext/has_nothrow_assign.C	(revision 131885)
+++ g++.dg/ext/has_nothrow_assign.C	(working copy)
@@ -136,13 +136,19 @@
   assert (PTEST (C));
   assert (NTEST (C[]));
   assert (PTEST (D));
+#ifndef __PIC__
   assert (PTEST (E));
+#endif
   assert (NTEST (E1));
   assert (PTEST (F));
   assert (PTEST (G));
+#ifndef __PIC__
   assert (PTEST (H));
+#endif
   assert (NTEST (H1));
+#ifndef __PIC__
   assert (PTEST (I));
+#endif
   assert (NTEST (I1));
   assert (PTEST (J));
   assert (NTEST (const K));
Index: g++.dg/ext/has_nothrow_copy.C
===================================================================
--- g++.dg/ext/has_nothrow_copy.C	(revision 131885)
+++ g++.dg/ext/has_nothrow_copy.C	(working copy)
@@ -126,13 +126,19 @@
   assert (PTEST (C));
   assert (NTEST (C[]));
   assert (PTEST (D));
+#ifndef __PIC__
   assert (PTEST (E));
+#endif
   assert (NTEST (E1));
   assert (PTEST (F));
   assert (PTEST (G));
+#ifndef __PIC__
   assert (PTEST (H));
+#endif
   assert (NTEST (H1));
+#ifndef __PIC__
   assert (PTEST (I));
+#endif
   assert (NTEST (I1));  
   assert (PTEST (J));
 
Index: g++.dg/ext/has_nothrow_constructor.C
===================================================================
--- g++.dg/ext/has_nothrow_constructor.C	(revision 131885)
+++ g++.dg/ext/has_nothrow_constructor.C	(working copy)
@@ -97,7 +97,9 @@
   assert (PTEST (C));
   assert (PTEST (C[]));
   assert (PTEST (D));
+#ifndef __PIC__
   assert (PTEST (E));
+#endif
   assert (NTEST (E1));
   assert (NTEST (F));
   assert (NTEST (G));

Re: [C++ PATCH]: testsuite PIC fix for has_nothrow* tests

[Kaveh R. GHAZI]

On Sun, 27 Jan 2008, Paolo Carlini wrote:

> Hi,
>
> see the discussion on the audit trail of c++/26099. I think we can just
> go with this simple fix, for 4.3.0 at least.
>
> Ok for mainline?
> Paolo.

Ping?
http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01330.html

(This fixes the last pic-specific error I get on mainline).

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu

Re: [C++ PATCH]: testsuite PIC fix for has_nothrow* tests

[Kaveh R. GHAZI]

On Sun, 10 Feb 2008, Kaveh R. GHAZI wrote:

> On Sun, 27 Jan 2008, Paolo Carlini wrote:
>
> > Hi,
> >
> > see the discussion on the audit trail of c++/26099. I think we can just
> > go with this simple fix, for 4.3.0 at least.
> >
> > Ok for mainline?
> > Paolo.
>
> Ping?
> http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01330.html
>
> (This fixes the last pic-specific error I get on mainline).

Hi Janis - would you please review this one for Paolo?  I'd like it to go
in before we branch 4.3.

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu

Re: [C++ PATCH]: testsuite PIC fix for has_nothrow* tests

[Janis Johnson]

On Thu, 2008-02-14 at 15:39 -0500, Kaveh R. GHAZI wrote:
> On Sun, 10 Feb 2008, Kaveh R. GHAZI wrote:
> 
> > On Sun, 27 Jan 2008, Paolo Carlini wrote:
> >
> > > Hi,
> > >
> > > see the discussion on the audit trail of c++/26099. I think we can just
> > > go with this simple fix, for 4.3.0 at least.
> > >
> > > Ok for mainline?
> > > Paolo.
> >
> > Ping?
> > http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01330.html
> >
> > (This fixes the last pic-specific error I get on mainline).
> 
> Hi Janis - would you please review this one for Paolo?  I'd like it to go
> in before we branch 4.3.

OK.

Please let me know about other testsuite patches I might
have missed.

Janis

Re: [C++ PATCH]: testsuite PIC fix for has_nothrow* tests

[Kaveh R. GHAZI]

On Fri, 15 Feb 2008, Janis Johnson wrote:

> On Thu, 2008-02-14 at 15:39 -0500, Kaveh R. GHAZI wrote:
> > On Sun, 10 Feb 2008, Kaveh R. GHAZI wrote:
> >
> > > On Sun, 27 Jan 2008, Paolo Carlini wrote:
> > >
> > > > Hi,
> > > >
> > > > see the discussion on the audit trail of c++/26099. I think we can just
> > > > go with this simple fix, for 4.3.0 at least.
> > > >
> > > > Ok for mainline?
> > > > Paolo.
> > >
> > > Ping?
> > > http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01330.html
> > >
> > > (This fixes the last pic-specific error I get on mainline).
> >
> > Hi Janis - would you please review this one for Paolo?  I'd like it to go
> > in before we branch 4.3.
>
> OK.
>
> Please let me know about other testsuite patches I might
> have missed.
> Janis


I think we're up to date on what I've submitted, (plus this one from
Paolo).  But I'm going to post at least one more (for 4.2) in a moment.

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu

Re: [C++ PATCH]: testsuite PIC fix for has_nothrow* tests

[Kaveh R. GHAZI]

On Fri, 15 Feb 2008, Janis Johnson wrote:

> On Thu, 2008-02-14 at 15:39 -0500, Kaveh R. GHAZI wrote:
> > On Sun, 10 Feb 2008, Kaveh R. GHAZI wrote:
> >
> > > On Sun, 27 Jan 2008, Paolo Carlini wrote:
> > >
> > > > Hi,
> > > >
> > > > see the discussion on the audit trail of c++/26099. I think we can just
> > > > go with this simple fix, for 4.3.0 at least.
> > > >
> > > > Ok for mainline?
> > > > Paolo.
> > >
> > > Ping?
> > > http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01330.html
> > >
> > > (This fixes the last pic-specific error I get on mainline).
> >
> > Hi Janis - would you please review this one for Paolo?  I'd like it to go
> > in before we branch 4.3.
>
> OK.
> Janis

Paolo - are you going to check this one in soon?  I'd like to have it
installed before Monday when the branch is created.  If you're busy, let
me know and I'll do it.

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu

Re: [C++ PATCH]: testsuite PIC fix for has_nothrow* tests

[Paolo Carlini]

Hi Kaveh,
> Paolo - are you going to check this one in soon?  I'd like to have it
> installed before Monday when the branch is created.  If you're busy, let
> me know and I'll do it.
sorry, I remained off-line for one day or so. Please commit it, if you
can, I'm now busy with other issues, otherwise I will, ASAP.

Thanks!
Paolo.