From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20964 invoked by alias); 2 Mar 2008 17:45:53 -0000 Received: (qmail 20946 invoked by uid 22791); 2 Mar 2008 17:45:50 -0000 X-Spam-Check-By: sourceware.org Received: from eastrmmtao101.cox.net (HELO eastrmmtao101.cox.net) (68.230.240.7) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Mar 2008 17:45:29 +0000 Received: from eastrmimpo01.cox.net ([68.1.16.119]) by eastrmmtao101.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20080302174528.NQQF22791.eastrmmtao101.cox.net@eastrmimpo01.cox.net>; Sun, 2 Mar 2008 12:45:28 -0500 Received: from [192.168.1.111] ([68.0.30.224]) by eastrmimpo01.cox.net with bizsmtp id wHl71Y0064q7hos02Hl77c; Sun, 02 Mar 2008 12:45:07 -0500 Message-ID: <47CAE864.40306@cox.net> Date: Sun, 02 Mar 2008 17:45:00 -0000 From: Andrew Hutchinson User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Anatoly Sokolov CC: "Weddington, Eric" , gcc-patches@gcc.gnu.org Subject: Re: Patch Fix PR1936,24894,31644,31786 AVR target References: <47A3F532.4020805@cox.net> <724785F6833842F7AA472B470C50E347@Vista> <47BCF39D.9020102@cox.net> In-Reply-To: <47BCF39D.9020102@cox.net> Content-Type: multipart/mixed; boundary="------------030306010104080901000605" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg00100.txt.bz2 This is a multi-part message in MIME format. --------------030306010104080901000605 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 836 I sent you this patch to approve and comit on 2008-02-2. It passed execute tests no regressions. Can it now be applied? Andrew Hutchinson wrote: > 2008-02-20 Andrew Hutchinson > > PR target/19636,24894,31644,31786 > * config/avr/avr.h (REG_ALLOC_ORDER_2): Move defintion from > avr.c. Re-order alternative 2. > (LEGITIMIZE_RELOAD_ADDRESS): Don't push base pointer as reload for > base pointer spill. > * config/avr/avr.c (legitimate_address_p): Expose address inside > subreg. Permit REG_X as base pointer. > (order_regs_for_local_alloc) Move constant definitions to avr.h. > (extra_constraint_Q): Add post-inc, pre-dec of X,Y Z to constraint. > * config/avr/avr.md (*movhi) Add Q constraint before m. > > > I am re-testing modified patch. (It takes a few hours.) > > > --------------030306010104080901000605 Content-Type: text/plain; name="spill3.diff" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="spill3.diff" Content-length: 6540 SW5kZXg6IGF2ci5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gYXZy LmMJKHJldmlzaW9uIDEzMjM4MCkNCisrKyBhdnIuYwkod29ya2luZyBjb3B5 KQ0KQEAgLTk3Niw2ICs5NzYsOCBAQA0KIAkJIHRydWVfcmVnbnVtIChYRVhQ ICh4LCAwKSkpOwogICAgICAgZGVidWdfcnR4ICh4KTsKICAgICB9CisgIGlm ICghc3RyaWN0ICYmIEdFVF9DT0RFICh4KSA9PSBTVUJSRUcpCisJeCA9IFNV QlJFR19SRUcgKHgpOwkJICAgCiAgIGlmIChSRUdfUCAoeCkgJiYgKHN0cmlj dCA/IFJFR19PS19GT1JfQkFTRV9TVFJJQ1RfUCAoeCkKICAgICAgICAgICAg ICAgICAgICAgOiBSRUdfT0tfRk9SX0JBU0VfTk9TVFJJQ1RfUCAoeCkpKQog ICAgIHIgPSBQT0lOVEVSX1JFR1M7CkBAIC05OTAsNiArOTkyLDcgQEANCiAg ICAgICBpZiAoZml0KQogCXsKIAkgIGlmICghIHN0cmljdAorCSAgICAgIHx8 IFJFR05PIChYRVhQICh4LDApKSA9PSBSRUdfWAogCSAgICAgIHx8IFJFR05P IChYRVhQICh4LDApKSA9PSBSRUdfWQogCSAgICAgIHx8IFJFR05PIChYRVhQ ICh4LDApKSA9PSBSRUdfWikKIAkgICAgciA9IEJBU0VfUE9JTlRFUl9SRUdT OwpAQCAtMTk1Nyw3ICsxOTYwLDcgQEANCiAJICAvKiBUaGlzIGlzIGEgcGFy YW5vaWQgY2FzZS4gTEVHSVRJTUlaRV9SRUxPQURfQUREUkVTUyBtdXN0IGV4 Y2x1ZGUKIAkgICAgIGl0IGJ1dCBJIGhhdmUgdGhpcyBzaXR1YXRpb24gd2l0 aCBleHRyZW1hbAogCSAgICAgb3B0aW1pemF0aW9uIG9wdGlvbnMuICAqLwot CSAgCisKIAkgICpsID0gNDsKIAkgIGlmIChyZWdfYmFzZSA9PSByZWdfZGVz dCkKIAkgICAgcmV0dXJuIChBUzIgKGFkaXcscjI2LCVvMSkgICAgICBDUl9U QUIKQEAgLTQ4NDAsNDMgKzQ4NDMsOSBAQA0KIG9yZGVyX3JlZ3NfZm9yX2xv Y2FsX2FsbG9jICh2b2lkKQogewogICB1bnNpZ25lZCBpbnQgaTsKLSAgc3Rh dGljIGNvbnN0IGludCBvcmRlcl8wW10gPSB7Ci0gICAgMjQsMjUsCi0gICAg MTgsMTksCi0gICAgMjAsMjEsCi0gICAgMjIsMjMsCi0gICAgMzAsMzEsCi0g ICAgMjYsMjcsCi0gICAgMjgsMjksCi0gICAgMTcsMTYsMTUsMTQsMTMsMTIs MTEsMTAsOSw4LDcsNiw1LDQsMywyLAotICAgIDAsMSwKLSAgICAzMiwzMywz NCwzNQotICB9OwotICBzdGF0aWMgY29uc3QgaW50IG9yZGVyXzFbXSA9IHsK LSAgICAxOCwxOSwKLSAgICAyMCwyMSwKLSAgICAyMiwyMywKLSAgICAyNCwy NSwKLSAgICAzMCwzMSwKLSAgICAyNiwyNywKLSAgICAyOCwyOSwKLSAgICAx NywxNiwxNSwxNCwxMywxMiwxMSwxMCw5LDgsNyw2LDUsNCwzLDIsCi0gICAg MCwxLAotICAgIDMyLDMzLDM0LDM1Ci0gIH07Ci0gIHN0YXRpYyBjb25zdCBp bnQgb3JkZXJfMltdID0gewotICAgIDI1LDI0LAotICAgIDIzLDIyLAotICAg IDIxLDIwLAotICAgIDE5LDE4LAotICAgIDMwLDMxLAotICAgIDI2LDI3LAot ICAgIDI4LDI5LAotICAgIDE3LDE2LAotICAgIDE1LDE0LDEzLDEyLDExLDEw LDksOCw3LDYsNSw0LDMsMiwKLSAgICAxLDAsCi0gICAgMzIsMzMsMzQsMzUK LSAgfTsKKyAgc3RhdGljIGNvbnN0IGludCBvcmRlcl8wW10gPSBSRUdfQUxM T0NfT1JERVJfMDsKKyAgc3RhdGljIGNvbnN0IGludCBvcmRlcl8xW10gPSBS RUdfQUxMT0NfT1JERVJfMTsKKyAgc3RhdGljIGNvbnN0IGludCBvcmRlcl8y W10gPSBSRUdfQUxMT0NfT1JERVJfMjsKICAgCiAgIGNvbnN0IGludCAqb3Jk ZXIgPSAoVEFSR0VUX09SREVSXzEgPyBvcmRlcl8xIDoKIAkJICAgICAgVEFS R0VUX09SREVSXzIgPyBvcmRlcl8yIDoKQEAgLTU0OTAsNiArNTQ1OSwxNCBA QA0KIAkgICAgICAgfHwgeHggPT0gYXJnX3BvaW50ZXJfcnR4KQogCXJldHVy biAxOwkJLyogWFhYIGZyYW1lICYgYXJnIHBvaW50ZXIgY2hlY2tzICovCiAg ICAgfQorCWVsc2UgaWYgIChHRVRfQ09ERSAoeCkgPT0gUFJFX0RFQyB8fCBH RVRfQ09ERSAoeCkgPT0gUE9TVF9JTkMpCisJeworCSAgaW50IHJlZ25vID0g UkVHTk8gKFhFWFAgKHgsIDApKTsKKwkgIGlmIChyZWdubyA9PSBSRUdfWiB8 fCByZWdubyA9PSBSRUdfWSB8fCByZWdubyA9PSBSRUdfWCkKKwkgICAgcmV0 dXJuIDE7CisJfQorCQorCQogICByZXR1cm4gMDsKIH0KIApAQCAtNTY5Miw3 ICs1NjY5LDcgQEANCiAgICAgcmV0dXJuIDE7CiAKICAgLyogTW9kZXMgbGFy Z2VyIHRoYW4gUUltb2RlIG9jY3VweSBjb25zZWN1dGl2ZSByZWdpc3RlcnMu ICAqLwotICBpZiAocmVnbm8gKyBHRVRfTU9ERV9TSVpFIChtb2RlKSA+IEZJ UlNUX1BTRVVET19SRUdJU1RFUikKKyAgaWYgKHJlZ25vIDw9IChSRUdfWiAr IDEpICYmIChyZWdubyArIEdFVF9NT0RFX1NJWkUgKG1vZGUpKSA+IChSRUdf WiArIDIpKQogICAgIHJldHVybiAwOwogCiAgIC8qIEFsbCBtb2RlcyBsYXJn ZXIgdGhhbiBRSW1vZGUgc2hvdWxkIHN0YXJ0IGluIGFuIGV2ZW4gcmVnaXN0 ZXIuICAqLwpJbmRleDogYXZyLmgNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N Ci0tLSBhdnIuaAkocmV2aXNpb24gMTMyMzgwKQ0KKysrIGF2ci5oCSh3b3Jr aW5nIGNvcHkpDQpAQCAtMTk5LDE5ICsxOTksMjkgQEANCiAgICAgMSwxLC8q ICBTVEFDSyAqLwkJCQlcCiAgICAgMSwxIC8qIGFyZyBwb2ludGVyICovICB9 CiAKLSNkZWZpbmUgUkVHX0FMTE9DX09SREVSIHsJCQlcCi0gICAgMjQsMjUs CQkJCQlcCi0gICAgMTgsMTksCQkJCQlcCi0gICAgMjAsMjEsCQkJCQlcCi0g ICAgMjIsMjMsCQkJCQlcCi0gICAgMzAsMzEsCQkJCQlcCi0gICAgMjYsMjcs CQkJCQlcCi0gICAgMjgsMjksCQkJCQlcCi0gICAgMTcsMTYsMTUsMTQsMTMs MTIsMTEsMTAsOSw4LDcsNiw1LDQsMywyLAlcCi0gICAgMCwxLAkJCQkJXAot ICAgIDMyLDMzLDM0LDM1CQkJCQlcCi0gICAgfQogCisjZGVmaW5lIFJFR19B TExPQ19PUkRFUl8wIHtcCisgICAgMjQsMjUsMTgsMTksMjAsMjEsMjIsMjMs MzAsMzEsMjYsMjcsMjgsMjksIFwKKyAgICAxNywxNiwxNSwxNCwxMywxMiwx MSwxMCw5LDgsNyw2LDUsNCwzLDIsXAorICAgIDAsMSxcCisgICAgMzIsMzMs MzQsMzUgfSAgIAorICAKKyNkZWZpbmUgUkVHX0FMTE9DX09SREVSXzEge1wK KyAgICAxOCwxOSwyMCwyMSwyMiwyMywyNCwyNSwzMCwzMSwyNiwyNywyOCwy OSxcCisgICAgMTcsMTYsMTUsMTQsMTMsMTIsMTEsMTAsOSw4LDcsNiw1LDQs MywyLFwKKyAgICAwLDEsXAorICAgIDMyLDMzLDM0LDM1IH0KKworI2RlZmlu ZSBSRUdfQUxMT0NfT1JERVJfMiB7XAorICAgIDE4LDIyLDIwLDI0LDE5LDIz LDIxLDI1LDMwLDMxLDI2LDI3LDI4LDI5LCBcCisgICAgMTcsMTYsMTUsMTQs MTMsMTIsMTEsMTAsOSw4LDcsNiw1LDQsMywyLFwKKyAgICAwLDEsXAorICAg IDMyLDMzLDM0LDM1IH0gCisKKworI2RlZmluZSBSRUdfQUxMT0NfT1JERVIg UkVHX0FMTE9DX09SREVSXzAKKworCiAjZGVmaW5lIE9SREVSX1JFR1NfRk9S X0xPQ0FMX0FMTE9DIG9yZGVyX3JlZ3NfZm9yX2xvY2FsX2FsbG9jICgpCiAK IApAQCAtNDUzLDExICs0NjMsMTQgQEANCiAJCSAgICAgICAgICAgT1BOVU0s IFRZUEUpOwkJCQkgICAgXAogCSAgICAgIGdvdG8gV0lOOwkJCQkJCQkgICAg XAogCSAgICB9CQkJCQkJCQkgICAgXAorICAgICAgICBpZigwKSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICB7ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogCSAgcHVzaF9y ZWxvYWQgKFhFWFAgKFgsIDApLCBOVUxMX1JUWCwgJlhFWFAgKFgsIDApLCBO VUxMLAkgICAgXAogCQkgICAgICAgQkFTRV9QT0lOVEVSX1JFR1MsIEdFVF9N T0RFIChYKSwgVk9JRG1vZGUsIDAsIDAsCSAgICBcCiAJCSAgICAgICBPUE5V TSwgVFlQRSk7CQkJCQkgICAgXAogICAgICAgICAgIGdvdG8gV0lOOwkJCQkJ CQkgICAgXAogCX0JCQkJCQkJCSAgICBcCisJfQkJCQkJCQkJICAgIFwKICAg ICAgIGVsc2UgaWYgKCEgKGZyYW1lX3BvaW50ZXJfbmVlZGVkICYmIFhFWFAg KFgsMCkgPT0gZnJhbWVfcG9pbnRlcl9ydHgpKSBcCiAJewkJCQkJCQkJICAg IFwKIAkgIHB1c2hfcmVsb2FkIChYLCBOVUxMX1JUWCwgJlgsIE5VTEwsCQkJ CSAgICBcCkluZGV4OiBhdnIubWQNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N Ci0tLSBhdnIubWQJKHJldmlzaW9uIDEzMjM4MCkNCisrKyBhdnIubWQJKHdv cmtpbmcgY29weSkNCkBAIC0yNTEsOCArMjUxLDggQEANCiAgICAoc2V0X2F0 dHIgImNjIiAibm9uZSIpXSkKIAogKGRlZmluZV9pbnNuICIqbW92aGkiCi0g IFsoc2V0IChtYXRjaF9vcGVyYW5kOkhJIDAgIm5vbmltbWVkaWF0ZV9vcGVy YW5kIiAiPXIscixtLGQsKnIscSxyIikKLSAgICAgICAgKG1hdGNoX29wZXJh bmQ6SEkgMSAiZ2VuZXJhbF9vcGVyYW5kIiAgICAgICAicixtLHJMLGksaSxy LHEiKSldCisgIFsoc2V0IChtYXRjaF9vcGVyYW5kOkhJIDAgIm5vbmltbWVk aWF0ZV9vcGVyYW5kIiAiPXIscixRbSxkLCpyLHEsciIpCisgICAgICAgICht YXRjaF9vcGVyYW5kOkhJIDEgImdlbmVyYWxfb3BlcmFuZCIgICAgICAgInIs UW0sckwsaSxpLHIscSIpKV0KICAgIihyZWdpc3Rlcl9vcGVyYW5kIChvcGVy YW5kc1swXSxISW1vZGUpCiAgICAgfHwgcmVnaXN0ZXJfb3BlcmFuZCAob3Bl cmFuZHNbMV0sSEltb2RlKSB8fCBjb25zdDBfcnR4ID09IG9wZXJhbmRzWzFd KSIKICAgIiogcmV0dXJuIG91dHB1dF9tb3ZoaSAoaW5zbiwgb3BlcmFuZHMs IE5VTEwpOyIK --------------030306010104080901000605--