From: Diego Novillo <dnovillo@google.com>
To: Oleg Ryjkov <olegr@google.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [tuples][patch] Converting several easy passes
Date: Wed, 05 Mar 2008 00:12:00 -0000 [thread overview]
Message-ID: <47CDD8F9.10406@google.com> (raw)
In-Reply-To: <20080304221827.GA23591@google.com>
On 3/4/08 5:18 PM, Oleg Ryjkov wrote:
> * tree-ssa-dse.c (execute_simple_dse): Tuplified.
> * gimplify.c (gimplify_return_expr): Copy the NO_WARNING flag
> to the newly created expr from the tree.
> * tree-cfg.c (gimplify_build1): Tuplified.
> * passes.c (init_optimization_passes): Enabled
> pass_warn_function_return, pass_update_address_taken,
> pass_simple_dse and pass_build_alias passes.
OK with some changes.
>
> - if (STORED_SYMS (stmt) && TREE_CODE (stmt) == GIMPLE_MODIFY_STMT
> - && TREE_CODE (stmt) != RETURN_EXPR
> - && !bitmap_intersect_p (STORED_SYMS (stmt), variables_loaded))
> + if (gimple_stored_syms (stmt) && (gimple_code (stmt) == GIMPLE_ASSIGN
> + || gimple_code (stmt) != GIMPLE_CALL)
> + && !bitmap_intersect_p (gimple_stored_syms (stmt), variables_loaded))
Why the change to gimple_code (stmt) != GIMPLE_RETURN?
> @@ -727,56 +726,46 @@ execute_simple_dse (void)
> /* Look for possible occurence var = indirect_ref (...) where
> indirect_ref itself is volatile. */
>
> - if (dead && TREE_THIS_VOLATILE (GIMPLE_STMT_OPERAND (stmt, 1)))
> + if (dead && gimple_code (stmt) == GIMPLE_ASSIGN &&
> + TREE_THIS_VOLATILE (gimple_assign_rhs1 (stmt)))
Align vertically.
Diego.
next prev parent reply other threads:[~2008-03-05 0:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 22:19 Oleg Ryjkov
2008-03-05 0:12 ` Diego Novillo [this message]
2008-03-05 0:47 ` Oleg Ryjkov
2008-03-05 3:43 ` Oleg Ryjkov
2008-03-05 3:46 ` Diego Novillo
2008-03-23 0:30 ` Jakub Staszak
2008-03-24 14:25 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CDD8F9.10406@google.com \
--to=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=olegr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).