From: Uros Bizjak <ubizjak@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, i386]: Committed: Fix PR target/35496
Date: Sun, 09 Mar 2008 17:07:00 -0000 [thread overview]
Message-ID: <47D4193B.2040404@gmail.com> (raw)
In-Reply-To: <6dc9ffc80803090726t6c1c7b86ob5c63c66e2c802b7@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
H.J. Lu wrote:
>> Patch was bootstrapped and regression tested on x86_64-pc-linux-gnu
>> {,-m32}. Patch is committed to mainline, but I think that it should be
>> committed to 4.3 branch as well.
>>
>
> Can we add a few testcases for Linux/ia32?
>
Actually, I have a testcase (attached), that clearly shows the problem
in the asm dump, but it looks that linker somehow fixed this alignment,
so I was not able to fail it (-m32 -O2 -msse2):
.section .rodata
.align 8
.LC0:
.long 1
.long 0
.long 2
.long 0
It looks that this fixup is the reason that the problem went undetected
for so long.
Uros.
[-- Attachment #2: vv.c --]
[-- Type: text/x-csrc, Size: 339 bytes --]
typedef long long __v2di __attribute__ ((__vector_size__ (16)));
typedef union
{
__v2di _v;
long long _a[2];
} __v2di_t;
void abort (void);
static __v2di x = { 1, 2 };
__v2di __attribute__((noinline))
test (void)
{
return x;
}
int main()
{
__v2di_t val;
val._v = test ();
if (val._a[0] + val._a[1] != 3)
abort ();
}
next prev parent reply other threads:[~2008-03-09 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-09 13:38 Uros Bizjak
2008-03-09 14:26 ` H.J. Lu
2008-03-09 17:07 ` Uros Bizjak [this message]
2008-03-09 17:33 ` H.J. Lu
2008-03-09 18:40 ` Uros Bizjak
2008-03-09 20:17 ` H.J. Lu
2008-03-09 20:53 ` Uros Bizjak
2008-03-10 14:58 ` Kaveh R. GHAZI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D4193B.2040404@gmail.com \
--to=ubizjak@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).