From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17120 invoked by alias); 10 Mar 2008 15:24:46 -0000 Received: (qmail 17111 invoked by uid 22791); 10 Mar 2008 15:24:45 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Mar 2008 15:24:24 +0000 Received: (qmail 26774 invoked from network); 10 Mar 2008 15:24:22 -0000 Received: from unknown (HELO ?192.168.0.2?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Mar 2008 15:24:22 -0000 Message-ID: <47D54E81.7020206@codesourcery.com> Date: Mon, 10 Mar 2008 15:24:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Paolo Carlini CC: Gcc Patch List Subject: Re: Renaming IS_AGGR_TYPE & co References: <47D1720D.5010206@suse.de> <47D453DB.1070802@codesourcery.com> <47D5172B.9010007@suse.de> In-Reply-To: <47D5172B.9010007@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg00626.txt.bz2 Paolo Carlini wrote: > Mark Mitchell wrote: >> Thank you for volunteering to working on this. > You are welcome. Many thanks for your help, I'm almost done. I have only > one remaining doubt (in init.c): > should aggr (aggregate) just become class? And it's ok to replace > IS_AGGR_TYPE with MAYBE_CLASS_TYPE_P or should be just CLASS_TYPE_P? In all three uses of that function, we want a class type, AFAICT. So, I would change the function to be is_class_type and use CLASS_TYPE_P as the predicate in the test. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713