From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26730 invoked by alias); 12 Mar 2008 15:27:37 -0000 Received: (qmail 26722 invoked by uid 22791); 12 Mar 2008 15:27:37 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Mar 2008 15:27:19 +0000 Received: from zps35.corp.google.com (zps35.corp.google.com [172.25.146.35]) by smtp-out.google.com with ESMTP id m2CFRGBJ014029 for ; Wed, 12 Mar 2008 08:27:16 -0700 Received: from nf-out-0910.google.com (nfic7.prod.google.com [10.48.255.7]) by zps35.corp.google.com with ESMTP id m2CFR4SV027855 for ; Wed, 12 Mar 2008 08:27:16 -0700 Received: by nf-out-0910.google.com with SMTP id c7so1673975nfi.35 for ; Wed, 12 Mar 2008 08:27:15 -0700 (PDT) Received: by 10.78.195.10 with SMTP id s10mr22401985huf.10.1205335634146; Wed, 12 Mar 2008 08:27:14 -0700 (PDT) Received: from dhcp-172-19-57-187.corp.google.com ( [172.19.57.187]) by mx.google.com with ESMTPS id 35sm1970246huc.14.2008.03.12.08.27.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 12 Mar 2008 08:27:12 -0700 (PDT) Message-ID: <47D7F644.3010406@google.com> Date: Wed, 12 Mar 2008 15:27:00 -0000 From: Diego Novillo User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213) MIME-Version: 1.0 To: Jakub Jelinek CC: Richard Henderson , gcc-patches@gcc.gnu.org Subject: Re: [gomp3] Task sharing fixes References: <20080311204141.GO24887@devserv.devel.redhat.com> In-Reply-To: <20080311204141.GO24887@devserv.devel.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg00738.txt.bz2 On 3/11/08 1:41 PM, Jakub Jelinek wrote: > @@ -1938,6 +1956,9 @@ lower_rec_input_clauses (tree clauses, t > needs to be delayed until after fixup_child_record_type so > that we get the correct type during the dereference. */ > by_ref = use_pointer_for_field (var, true); > + /* For tasks copy-out is not possible, so force by_ref. */ Could you add an explanation why this is not possible in some comment? Thanks. Diego.