From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11829 invoked by alias); 14 Mar 2008 10:06:55 -0000 Received: (qmail 11778 invoked by uid 22791); 14 Mar 2008 10:06:54 -0000 X-Spam-Check-By: sourceware.org Received: from fg-out-1718.google.com (HELO fg-out-1718.google.com) (72.14.220.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 10:06:29 +0000 Received: by fg-out-1718.google.com with SMTP id d23so3041763fga.28 for ; Fri, 14 Mar 2008 03:06:27 -0700 (PDT) Received: by 10.86.62.3 with SMTP id k3mr4180553fga.71.1205489187042; Fri, 14 Mar 2008 03:06:27 -0700 (PDT) Received: from ?192.168.76.107? ( [195.176.176.226]) by mx.google.com with ESMTPS id 4sm14413804fge.3.2008.03.14.03.06.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 14 Mar 2008 03:06:26 -0700 (PDT) Message-ID: <47DA4E23.1060804@gnu.org> Date: Fri, 14 Mar 2008 10:07:00 -0000 From: Paolo Bonzini User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213) MIME-Version: 1.0 To: Richard Guenther CC: Oleg Ryjkov , gcc-patches@gcc.gnu.org, Diego Novillo Subject: Re: [tuples][patch] Removing gimplify_val References: <14be89990803131659i6f5e18c6hcdb62d81f2f7190d@mail.gmail.com> <84fc9c000803140237k278dacbai407677c4c0cae575@mail.gmail.com> In-Reply-To: <84fc9c000803140237k278dacbai407677c4c0cae575@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg00867.txt.bz2 >> This patch removes gimplify_val and updates the callers, since it >> basically duplicates what is done by force_gimple_operands_gsi, which >> in turn is more general and used way more often. >> Tested on i686-linux - no new failures, 1 testcase fixed. >> Diego, OK to commit? > > Can you do so on the trunk as well? The only difference I see with > the two functions is that gimplify_val sets location information on > the new stmt - you may want to do some digging in the archives > for what reason this went in and eventually update force_gimple_operand_bsi > to do so as well. It was there since the beginning. Since gimplify_val is used in complex lowering, and the original complex-type instructions are deleted, locations were added to keep debuggability at -O0. Paolo