From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-213812-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 30327 invoked by alias); 14 Mar 2008 14:21:17 -0000
Received: (qmail 30318 invoked by uid 22791); 14 Mar 2008 14:21:16 -0000
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Mar 2008 14:20:54 +0000
Received: from zps77.corp.google.com (zps77.corp.google.com [172.25.146.77]) 	by smtp-out.google.com with ESMTP id m2EEKq1d003673 	for <gcc-patches@gcc.gnu.org>; Fri, 14 Mar 2008 07:20:52 -0700
Received: from nf-out-0910.google.com (nfde27.prod.google.com [10.48.131.27]) 	by zps77.corp.google.com with ESMTP id m2EEKoCu018299 	for <gcc-patches@gcc.gnu.org>; Fri, 14 Mar 2008 07:20:51 -0700
Received: by nf-out-0910.google.com with SMTP id e27so1585333nfd.13         for <gcc-patches@gcc.gnu.org>; Fri, 14 Mar 2008 07:20:50 -0700 (PDT)
Received: by 10.78.165.16 with SMTP id n16mr30402051hue.59.1205504448668;         Fri, 14 Mar 2008 07:20:48 -0700 (PDT)
Received: from dhcp-172-19-57-187.corp.google.com ( [172.19.57.187])         by mx.google.com with ESMTPS id 4sm8575682hue.17.2008.03.14.07.20.46         (version=TLSv1/SSLv3 cipher=RC4-MD5);         Fri, 14 Mar 2008 07:20:47 -0700 (PDT)
Message-ID: <47DA89BD.2050004@google.com>
Date: Fri, 14 Mar 2008 14:21:00 -0000
From: Diego Novillo <dnovillo@google.com>
User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213)
MIME-Version: 1.0
To: Richard Guenther <richard.guenther@gmail.com>
CC: Oleg Ryjkov <olegr@google.com>, gcc-patches@gcc.gnu.org
Subject: Re: [tuples][patch] Removing gimplify_val
References: <14be89990803131659i6f5e18c6hcdb62d81f2f7190d@mail.gmail.com> <84fc9c000803140237k278dacbai407677c4c0cae575@mail.gmail.com>
In-Reply-To: <84fc9c000803140237k278dacbai407677c4c0cae575@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2008-03/txt/msg00882.txt.bz2

On 3/14/08 2:37 AM, Richard Guenther wrote:

> Can you do so on the trunk as well?  The only difference I see with
> the two functions is that gimplify_val sets location information on
> the new stmt - you may want to do some digging in the archives
> for what reason this went in and eventually update force_gimple_operand_bsi
> to do so as well.

Good idea.  Oleg, please submit this patch for mainline.  Make 
force_gimple_operand_gsi set the location of all the statements in STMTS 
in the loop that scans for symbols to rename.


Diego.