From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7200 invoked by alias); 20 Mar 2008 17:15:47 -0000 Received: (qmail 7192 invoked by uid 22791); 20 Mar 2008 17:15:46 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Mar 2008 17:15:19 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m2KHFFQJ029507; Thu, 20 Mar 2008 13:15:15 -0400 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m2KHFE7W006306; Thu, 20 Mar 2008 13:15:14 -0400 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by lacrosse.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id m2KHFEPh009659; Thu, 20 Mar 2008 13:15:14 -0400 Message-ID: <47E29BA2.1030204@redhat.com> Date: Thu, 20 Mar 2008 18:46:00 -0000 From: Jason Merrill User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: George Helffrich CC: "gcc-patches@@gcc.gnu.org" , FX Coudert , John David Anglin , wilson@cygnus.com Subject: Re: [PATCH,fortran]: Emit COMMON identifiers in proper debug scope References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg01224.txt.bz2 It looks like this patch can generate DW_TAG_common_block for languages other than FORTRAN, which seems undesirable. Specifically, it seems that any use of DECL_VALUE_EXPR could trigger this code, such as anonymous unions in C++. I notice that you even have C++-specific code in common_check. Jason