Re: [PATCH] Build system cleanups 1/4

[Paolo Bonzini <bonzini@gnu.org>]

Andreas Schwab wrote:
> Paolo Bonzini <bonzini@gnu.org> writes:
> 
>> This one removes the PICFLAG variables, which are never set, as well as
>> the makefile fragments that used to set PICFLAG *at the time of Cygnus
>> configure*.
>>
>> Committed to gcc and (shortly) to src.
> 
> AFAICS this is used by libiberty when --enable-shared.

Also, considering that libstdc++ compiles its own cp-demangle.c, and has 
always done so since it started using the libiberty demangler (r78553):

cp-demangle.c:
         rm -f $@
         $(LN_S) $(toplevel_srcdir)/libiberty/cp-demangle.c $@
cp-demangle.lo: cp-demangle.c
         $(LTCOMPILE) -DIN_GLIBCPP_V3 -Wno-error -c $<
cp-demangle.o: cp-demangle.c
         $(C_COMPILE) -DIN_GLIBCPP_V3 -Wno-error -c $<

I wonder why we still compile libiberty for the target at all.  Neither 
it nor libobjc needs it, which would leave only all-target-fastjar 
(which is a bogus target anyway) and all-target-winsup.

Cygwin people, does winsup actually need a target libiberty?  If so, 
were you aware that the target libiberty is not compiled as PIC?

Paolo