From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id E2189385840E; Sun, 20 Aug 2023 17:44:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2189385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fe4f3b5f25so5554795e9.0; Sun, 20 Aug 2023 10:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692553481; x=1693158281; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=RpAfi+mQYiF5czWYBCo1XfIdlmNm8WMPbYjugDL+CSY=; b=Z2dVzrzkdiu8ajEz0mGpB2DxUCvIdcdOQLlDgDJeqhLrHBfnGzHdDJLUpyfgJ4V6zD lpHg7IpI43oawzYa6lIaJxmRVY4GnzVKcKVEX8F5kwFtatdPO2X6jSpepWMJdxAS5H78 r9P5S1xHl9QliPO9QcTQEnpLhYkezJvCFcrSdan7s7wcnM4qH6AKsgDlK3DDz6XoYJxR rBR+PbNJt6ASoRs/2LOXnDxQ9UHEJeMF15oZ141ehAAZtXjSw0d1i9eEiz8Kt494MBB9 qg4VYuDvYxgiCIkNlMxo0o2AnQzvsIpMcbozA9z2SKNeLDboWODRo21Ms0zdqTBriYTg /eDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692553481; x=1693158281; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RpAfi+mQYiF5czWYBCo1XfIdlmNm8WMPbYjugDL+CSY=; b=aZXZRSbmh45V/xHNGqi5lSWAfRPWn8pIPqYvHwhLazdSxLk6dWOl7kXVH8y1JWOpEB PINVbfSLFTqqU36LfPtlOey6d1XcllZ2A2cJFcttZM/H4R0cQUnDy4hc/eKBM4w/wA94 AghDNJ1IA5kDTOSSXi3Tu2WplTZTMmvNJ5/7EQ5QFgCXObU+1l8FfP6+W7XkWyi7EnIH cEI1w0tcwe+P2jvof5G3mjd6rHsWahNjuiqg1LBwpIKHmeV5nN3rHd5NIDIUNBj4Dk76 AeaZ3kNguBhnIlSKy/AcotgskBRDl8hm+KmGXkevBUpazLxVsnZ87Uz91FftgtQ6hTpz /1Zg== X-Gm-Message-State: AOJu0Yz73dTB9w/wdXwjkALVr5kNmgaDMT3ljz+JM2HqiUYCi5t4HrZ8 3S7s8ijpClmYa0shb2mjyyo= X-Google-Smtp-Source: AGHT+IEcd8w7nvnwuHeQDXFfuW6RxNireM6saEhzdGrouFnUYSftPQ0qqn9NQDvOG0Wti1IEt8PmeQ== X-Received: by 2002:a05:600c:3b22:b0:3fe:21a6:a18 with SMTP id m34-20020a05600c3b2200b003fe21a60a18mr4219535wms.3.1692553481173; Sun, 20 Aug 2023 10:44:41 -0700 (PDT) Received: from smtpclient.apple ([178.132.107.5]) by smtp.gmail.com with ESMTPSA id hn40-20020a05600ca3a800b003fe61c33df5sm13634370wmb.3.2023.08.20.10.44.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Aug 2023 10:44:40 -0700 (PDT) From: FX Coudert Message-Id: <47FE3A1C-DC0F-4B53-B23F-885981136B92@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_E7DFE28E-0991-4BA3-9C05-8D77D5FE4144" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [PATCH] Testsuite: mark IPA test as requiring alias support Date: Sun, 20 Aug 2023 19:42:18 +0200 In-Reply-To: <9D4788E3-0C89-4179-82A0-0FA3A0894243@googlemail.com> Cc: GCC Patches , marxin@gcc.gnu.org To: Iain Sandoe References: <9D4788E3-0C89-4179-82A0-0FA3A0894243@googlemail.com> X-Mailer: Apple Mail (2.3731.600.7) X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_E7DFE28E-0991-4BA3-9C05-8D77D5FE4144 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, > IMO, changes like this qualify as obvious, so I=E2=80=99d go ahead = (thanks for this test fail triage) Makes sense. I=E2=80=99ve committed, as well as another one, attached, = slightly amending the expected pattern of a sarif plugin test. FX --Apple-Mail=_E7DFE28E-0991-4BA3-9C05-8D77D5FE4144 Content-Disposition: attachment; filename=0001-Testsuite-plugin-make-testcase-pattern-more-flexible.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Testsuite-plugin-make-testcase-pattern-more-flexible.patch" Content-Transfer-Encoding: quoted-printable =46rom=207be59c50478462a4bba81cddb5d2af038d4c1b1a=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Francois-Xavier=20Coudert=20= =0ADate:=20Sun,=2020=20Aug=202023=2019:35:18=20= +0200=0ASubject:=20[PATCH]=20Testsuite,=20plugin:=20make=20testcase=20= pattern=20more=20flexible=0A=0AOn=20Darwin,=20the=20message=20recorded=20= in=20the=20sarif=20file=20contains:=0A=20=20"message":=20{"text":=20= "Segmentation=20fault:=2011"}=0Awhich=20is=20different=20from,=20e.g.,=20= linux:=0A=20=20"message":=20{"text":=20"Segmentation=20fault"}=0A=0A= Adjusting=20the=20testcase=20pattern=20to=20be=20a=20little=20more=20= flexible.=0A=0Agcc/testsuite/ChangeLog:=0A=09*=20= gcc.dg/plugin/crash-test-write-though-null-sarif.c:=20Update=0A=09= expected=20pattern.=0A---=0A=20= .../gcc.dg/plugin/crash-test-write-though-null-sarif.c=20=20=20=20=20=20=20= =20=20=20|=202=20+-=0A=201=20file=20changed,=201=20insertion(+),=201=20= deletion(-)=0A=0Adiff=20--git=20= a/gcc/testsuite/gcc.dg/plugin/crash-test-write-though-null-sarif.c=20= b/gcc/testsuite/gcc.dg/plugin/crash-test-write-though-null-sarif.c=0A= index=2083b38d2ffb5..513d66c528d=20100644=0A---=20= a/gcc/testsuite/gcc.dg/plugin/crash-test-write-though-null-sarif.c=0A+++=20= b/gcc/testsuite/gcc.dg/plugin/crash-test-write-though-null-sarif.c=0A@@=20= -61,4=20+61,4=20@@=20void=20test_inject_write_through_null=20(void)=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20{=20dg-final=20{=20= scan-sarif-file=20"\"startColumn\":=203"=20}=20}=0A=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20{=20dg-final=20{=20scan-sarif-file=20= "\"endColumn\":=2031"=20}=20}=0A=20=20=20=20=20=20=20=20=20=20{=20= dg-final=20{=20scan-sarif-file=20"\"message\":=20"=20}=20}=0A-=20=20=20=20= =20=20=20=20=20=20=20{=20dg-final=20{=20scan-sarif-file=20"\"text\":=20= \"Segmentation=20fault\""=20}=20}=20*/=0A+=20=20=20=20=20=20=20=20=20=20=20= {=20dg-final=20{=20scan-sarif-file=20"\"text\":=20\"Segmentation=20= fault"=20}=20}=20*/=0A--=20=0A2.39.2=20(Apple=20Git-143)=0A=0A= --Apple-Mail=_E7DFE28E-0991-4BA3-9C05-8D77D5FE4144--