From: David Malcolm <dmalcolm@redhat.com>
To: "Ankur Saini" <arsenic.secondary@gmail.com>,
"Martin Liška" <mliska@suse.cz>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] analyzer: Impose recursion limit on indirect calls.
Date: Wed, 25 Aug 2021 11:05:29 -0400 [thread overview]
Message-ID: <47cb93b4727ae6e4ff0f37e22947cc72705bf580.camel@redhat.com> (raw)
In-Reply-To: <9C51062C-3457-4345-9BDC-20F7FE4BFA1E@gmail.com>
On Wed, 2021-08-25 at 20:31 +0530, Ankur Saini wrote:
>
>
> > On 25-Aug-2021, at 7:24 PM, Martin Liška <mliska@suse.cz> wrote:
> >
> > On 8/25/21 15:22, David Malcolm via Gcc-patches wrote:
> > > On Wed, 2021-08-25 at 13:39 +0530, Ankur Saini wrote:
> > > > This should also fix the failing regression found in PR
> > > > analyzer/101980.
> > > >
> > > > - The patch is in sync with current master
> > > > - successfully bootstrapped and tested on x86_64-linux-gnu.
> > > >
> > > The patch is OK for trunk.
> > > Thanks for fixing this
> > > Dave
> >
> > Hello.
> >
> > Quite accidentally, but I noticed the patch violates GNU coding
> > style:
> >
> > $ git show 43a5d46feabd93ba78983919234f05f5fc9a0982 |
> > ./contrib/check_GNU_style.py -
> >
> > === ERROR type #1: blocks of 8 spaces should be replaced with tabs
> > (8 error(s)) ===
> >
> > gcc/analyzer/engine.cc:3064:0:████████ that exceed it further.
> >
> > gcc/analyzer/engine.cc:3065:0:████████ This is something of a blunt
> > workaround, but it only
> >
> > gcc/analyzer/engine.cc:3066:0:████████ applies to recursion (and
> > mutual recursion), not to
> >
> > gcc/analyzer/engine.cc:3067:0:████████ general call stacks. */
> >
> > gcc/analyzer/engine.cc:3069:0:████████ >
> > param_analyzer_max_recursion_depth)
> >
> > gcc/analyzer/engine.cc:3071:0:████████if (logger)
> >
> > gcc/analyzer/engine.cc:3072:0:████████ logger->log ("rejecting
> > call edge: recursion limit exceeded");
> >
> > gcc/analyzer/engine.cc:3073:0:████████return false;
> >
>
> Looks like my editor again converted all the tabs to spaces.
>
> btw, I can also see a lot of other places where 8 spaces are not
> begin converted to tabs, should I also change that accordingly or
> leave them the way it is and just update this patch ?
It's usually best to split out bugfixes from formatting/whitespace
changes, so maybe do it as two patches:
(1) an updated version of this patch to fix the recursion issue, using
the correct whitespace for the lines that are touched
(2) a patch that fixes whitespaces issues, but doesn't change the
behavior of the code
Dave
next prev parent reply other threads:[~2021-08-25 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 8:09 Ankur Saini
2021-08-25 13:22 ` David Malcolm
2021-08-25 13:54 ` Martin Liška
[not found] ` <9C51062C-3457-4345-9BDC-20F7FE4BFA1E@gmail.com>
2021-08-25 15:05 ` David Malcolm [this message]
2021-08-25 15:55 ` Ankur Saini
2021-08-25 17:15 ` David Malcolm
2021-08-27 12:44 ` Ankur Saini
2021-08-27 12:58 ` Martin Liška
2021-09-20 12:36 ` Ankur Saini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47cb93b4727ae6e4ff0f37e22947cc72705bf580.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=arsenic.secondary@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).