From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 5137C385701D for ; Fri, 12 May 2023 13:33:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5137C385701D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-96649b412easo1135060966b.0 for ; Fri, 12 May 2023 06:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683898406; x=1686490406; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9aJdiyqmVAFerpy4MTRxhbRoEzZeLYS7XJ6t2lf4/vk=; b=JfZW7mRht45A9ZPgZQTKiLVGprlS5e92UKu6xqq06ldKdcnFj/v4P8aYALl8d+6pFd KfRXX0dYEM0BRztVwtAhptxqDWM49uVUpsbe1omYc8XhEDPRzvy81R0qe2D/9PfZiO+w 4etwyTfJ1xObCZK8I3yLfeM6nvzEDUtPPiiwAuYCCaZJ9AuedssGe/EEq1EZ+b36z3bK 7tDgwIGhBD/MO7ySpnfvmMlzG4/mD6PMa6LXb+fCR8zmeeF8nBSxaE7iIwviJe2shhSU oiuEAWCDE8/qgfw1v09pcmYeeIw4f24GlykEqmP0AbOhczXMb//nTU5RLwj2r5EAFKiM AduQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683898406; x=1686490406; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9aJdiyqmVAFerpy4MTRxhbRoEzZeLYS7XJ6t2lf4/vk=; b=ZnzgMIXZ0nHqR15LwyDrcwakaowhC/RSIU9Q+XxXvEy4mmX5AU25eX8vYclXYWL1Uw KSQMY/XwjivxTDBq9Sp+9XpoRcbJukO9egcZvHWyf6uwgsA4wSqw5Hj1EG58Bw9a0yZB IT6E0/PVFNK/FVyt6GTzjZKACAADocoXSiWOBdDDhb2yJ+OoTZwxWCeFcQBBuDugupgL UGBwH+LTJwCncpd73wg5avZN9cmFcEho2yAVhEmAgSabWUGRq/apJfwcb3dWfTwlh4Kp JLJ1251uYi98PyKSxUGBKVeokYMrop2WM2s2WW5Jtd9OJ7yHqkqbz51I7rwfRbJOZr+X WEBg== X-Gm-Message-State: AC+VfDzNU5OQFYcXR688MCL45am/Ol8RHhi2corLKqI35PmdW+IuJfBj 3imSbNemxMc/d++wA+86b/8= X-Google-Smtp-Source: ACHHUZ4EK2EujAtcYqnyI7aTKAbuwQTfnRnaRFElYgR8simC3UOdC74FXXyotOR0BrY5BfICnF88uA== X-Received: by 2002:a17:907:ea4:b0:969:fd4b:554a with SMTP id ho36-20020a1709070ea400b00969fd4b554amr12215145ejc.24.1683898405731; Fri, 12 May 2023 06:33:25 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id i19-20020a170906265300b0096595cc0810sm5469640ejc.72.2023.05.12.06.33.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 06:33:25 -0700 (PDT) Message-ID: <47e5da8a-c64c-c9c3-907d-e0c813e93b25@gmail.com> Date: Fri, 12 May 2023 15:33:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: rdapp.gcc@gmail.com, "gcc-patches@gcc.gnu.org" , "kito.cheng@gmail.com" , "palmer@dabbelt.com" , "jeffreyalaw@gmail.com" Subject: Re: [PATCH] RISC-V: Using merge approach to optimize repeating sequence in vec_init Content-Language: en-US To: "juzhe.zhong" References: <20230512104412.170581-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > emit_merge_op can not be wrapped into binop since mask position is > different in pattern. > > I prefer merge op in different wrapper. Yes, I didn't mean literally the same but that things already become a bit confusing with all the different variants and bool arguments or code duplication with slight differences. Something like foo (true, false, true) is a bit of a code smell. Nothing to address immediately, I just need to keep an eye on it. Shouldn't prevent the patch from going in.