From: Jason Merrill <jason@redhat.com>
To: Alexandre Oliva <aoliva@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] [PR c++/87814] undefer deferred noexcept on tsubst if request
Date: Fri, 14 Dec 2018 20:31:00 -0000 [thread overview]
Message-ID: <47fe9b29-a9e8-127b-acc5-0db527b0795c@redhat.com> (raw)
In-Reply-To: <ora7likx2f.fsf@lxoliva.fsfla.org>
On 12/6/18 7:19 PM, Alexandre Oliva wrote:
> tsubst_expr and tsubst_copy_and_build are not expected to handle
> DEFERRED_NOEXCEPT exprs, but if tsubst_exception_specification takes a
> DEFERRED_NOEXCEPT expr with !defer_ok, it just passes the expr on for
> tsubst_copy_and_build to barf.
>
> This patch arranges for tsubst_exception_specification to combine the
> incoming args with those already stored in a DEFERRED_NOEXCEPT, and
> then substitute them into the pattern, when retaining a deferred
> noexcept is unacceptable.
>
> Regstrapped on x86_64- and i686-linux-gnu, mistakenly along with a patch
> with a known regression, and got only that known regression. Retesting
> without it. Ok to install?
OK.
Jason
prev parent reply other threads:[~2018-12-14 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 0:19 Alexandre Oliva
2018-12-14 20:16 ` Alexandre Oliva
2018-12-21 12:25 ` [committed] Add testcase for already fixed PR c++/87125 Jakub Jelinek
2018-12-14 20:31 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47fe9b29-a9e8-127b-acc5-0db527b0795c@redhat.com \
--to=jason@redhat.com \
--cc=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).