From: Jason Merrill <jason@redhat.com>
To: Mark Mitchell <mark@codesourcery.com>
Cc: Jakub Jelinek <jakub@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Fix vector_size handling in templates (PR c++/35758)
Date: Sat, 19 Apr 2008 01:34:00 -0000 [thread overview]
Message-ID: <480901CB.4020308@redhat.com> (raw)
In-Reply-To: <47FBC7C3.7080501@codesourcery.com>
Mark Mitchell wrote:
> Jason Merrill wrote:
>> I believe this patch is appropriate and correct and fixes the
>> regression, regardless of whether we also try to implement deduction
>> for 'vector T'. If reconstruct_complex_type doesn't do the right
>> thing for C++, this is the way to fix it.
>
> Yes, that's true. Then again, given that reconstruct_complex_type is
> documented as:
>
> /* HACK. GROSS. This is absolutely disgusting.
>
> perhaps we should try to figure out how not to need this?
Anyway, yes, but I'd still like to get this patch in to fix the
important regression.
Jason
next prev parent reply other threads:[~2008-04-18 20:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 14:37 Jakub Jelinek
2008-04-01 16:23 ` Mark Mitchell
2008-04-01 16:39 ` Andrew Pinski
2008-04-01 16:44 ` Mark Mitchell
2008-04-02 13:10 ` Jakub Jelinek
2008-04-07 17:42 ` Jason Merrill
2008-04-08 10:18 ` Jakub Jelinek
2008-04-08 10:34 ` Andrew Pinski
2008-04-08 19:52 ` Mark Mitchell
2008-04-09 13:13 ` Jakub Jelinek
2008-04-10 16:53 ` Jason Merrill
2008-04-19 1:34 ` Jason Merrill [this message]
2008-04-23 15:34 ` Jason Merrill
2008-04-24 8:59 ` Mark Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480901CB.4020308@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).