From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3247 invoked by alias); 24 Apr 2008 03:04:29 -0000 Received: (qmail 3234 invoked by uid 22791); 24 Apr 2008 03:04:29 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 Apr 2008 03:04:11 +0000 Received: (qmail 24812 invoked from network); 24 Apr 2008 03:04:09 -0000 Received: from unknown (HELO ?192.168.0.2?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Apr 2008 03:04:09 -0000 Message-ID: <480FF8A3.7040400@codesourcery.com> Date: Thu, 24 Apr 2008 08:59:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Jason Merrill CC: Jakub Jelinek , gcc-patches@gcc.gnu.org Subject: Re: [C++ PATCH] Fix vector_size handling in templates (PR c++/35758) References: <20080401143240.GR30807@devserv.devel.redhat.com> <47FA5AA6.7010802@redhat.com> <47FBC7C3.7080501@codesourcery.com> <480F3FCB.7000800@redhat.com> In-Reply-To: <480F3FCB.7000800@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-04/txt/msg01815.txt.bz2 Jason Merrill wrote: >> /* HACK. GROSS. This is absolutely disgusting. >> >> perhaps we should try to figure out how not to need this? > > As Jakub wrote in the PR yesterday, > > 'Especially for 4.3.x getting rid of the "HACK. GROSS. This is > absolutely disgusting." might not be something desirable for a stable > branch. > > I agree with this. Finding a better way would be nice for 4.4, but > trying to rewrite type attribute handling is inappropriate for 4.3. I fully agree. -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713