From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125163 invoked by alias); 28 Nov 2017 16:36:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 125153 invoked by uid 89); 28 Nov 2017 16:36:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Nov 2017 16:36:18 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E7B781224; Tue, 28 Nov 2017 16:36:17 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-12.rdu2.redhat.com [10.10.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 603825D962; Tue, 28 Nov 2017 16:36:15 +0000 (UTC) Subject: Re: [077/nnn] poly_int: vect_get_constant_vectors To: gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org References: <871sltvm7r.fsf@linaro.org> <87mv4hhitu.fsf@linaro.org> From: Jeff Law Message-ID: <481419f3-7de1-dc7c-95b1-52b59a869709@redhat.com> Date: Tue, 28 Nov 2017 16:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <87mv4hhitu.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg02423.txt.bz2 On 10/23/2017 11:31 AM, Richard Sandiford wrote: > For now, vect_get_constant_vectors can only cope with constant-length > vectors, although a patch after the main SVE submission relaxes this. > This patch adds an appropriate guard for variable-length vectors. > The TYPE_VECTOR_SUBPARTS use in vect_get_constant_vectors will then > have a to_constant call when TYPE_VECTOR_SUBPARTS becomes a poly_int. > > > 2017-10-23 Richard Sandiford > Alan Hayward > David Sherwood > > gcc/ > * tree-vect-slp.c (vect_get_and_check_slp_defs): Reject > constant and extern definitions for variable-length vectors. > (vect_get_constant_vectors): Note that the number of units > is known to be constant. OK. jeff ps. Sorry about the strange ordering of acks. I'm trying to work through the simple stuff and come back to the larger patches. The only way to eat an elephant is a bite at a time...