From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27367 invoked by alias); 28 Apr 2008 17:07:21 -0000 Received: (qmail 27358 invoked by uid 22791); 28 Apr 2008 17:07:20 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Apr 2008 17:06:51 +0000 Received: (qmail 31436 invoked from network); 28 Apr 2008 17:06:47 -0000 Received: from unknown (HELO ?192.168.0.2?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Apr 2008 17:06:47 -0000 Message-ID: <4816041B.9060300@codesourcery.com> Date: Mon, 28 Apr 2008 20:43:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Jakub Jelinek CC: Jason Merrill , gcc-patches@gcc.gnu.org Subject: Re: C++ patch ping References: <20080428162806.GV2255@devserv.devel.redhat.com> In-Reply-To: <20080428162806.GV2255@devserv.devel.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-04/txt/msg02054.txt.bz2 Jakub Jelinek wrote: > - http://gcc.gnu.org/ml/gcc-patches/2008-04/msg01609.html PR c++/35650 I think this patch is OK. As you say, we could also change reference_binding or initialize_reference, but the general policy in the front end has been to resolve single OVERLOADs at the point of lookup. In fact, if we were you going to make a more substantial change here, it would probably be to have the USING_DECL record only a FUNCTION_DECL, rather than an OVERLOAD. > - http://gcc.gnu.org/ml/gcc-patches/2008-04/msg01559.html PR c++/35987 This is OK, too, though I would prefer using error_operand_p to the direct comparision with error_mark_node. In this case, error_mark_node is probably correct -- but using error_operand_p for expressions is more mnemonic. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713