From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17982 invoked by alias); 28 Apr 2008 17:30:43 -0000 Received: (qmail 17959 invoked by uid 22791); 28 Apr 2008 17:30:42 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 28 Apr 2008 17:30:25 +0000 Received: (qmail 32046 invoked from network); 28 Apr 2008 17:30:21 -0000 Received: from unknown (HELO ?192.168.0.2?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Apr 2008 17:30:21 -0000 Message-ID: <481609A2.900@codesourcery.com> Date: Mon, 28 Apr 2008 20:59:00 -0000 From: Mark Mitchell User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Jakub Jelinek CC: Jason Merrill , gcc-patches@gcc.gnu.org Subject: Re: C++ patch ping References: <20080428162806.GV2255@devserv.devel.redhat.com> <4816041B.9060300@codesourcery.com> <20080428172015.GW2255@devserv.devel.redhat.com> In-Reply-To: <20080428172015.GW2255@devserv.devel.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-04/txt/msg02057.txt.bz2 Jakub Jelinek wrote: > So, if I should use error_operand_p instead, I guess it should be changed > consistently for all 3 cases, or none. Oh, I see. My brain's being a little dumb. Yes, we can rely on cp_build_modify_expr to return an error_mark_node on error, and in that case it's fine as is. So, go with your original patch. Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713