Re: [PATCH] jit: Ensure ssize_t is defined.

[FX Coudert <fxcoudert@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1071 bytes --]

Can I please get an approval on that one? It’s been there since January, I’ve amended it following review, but cannot get a definite ok. It is five lines.

Bootstrapped on x86_64-apple-darwin23. OK to push?

FX


> Le 7 sept. 2024 à 19:35, FX Coudert <fxcoudert@gmail.com> a écrit :
> 
> ping**many on this patch, originally from January.
> In latest round, Richard suggested that David should have the last say, I’ve never had any response.
> 
> 
>> Le 27 juin 2024 à 19:08, FX Coudert <fxcoudert@gmail.com> a écrit :
>> 
>> Among the review comments from the last round, Jakub suggested:
>> 
>>> Perhaps libgccjit.h could use
>>> #ifdef __has_include
>>> #if __has_include (<sys/types.h>)
>>> #include <sys/types.h>
>>> #endif
>>> #endif
>>> instead of just #include <sys/types.h>.
>> 
>> I’m not sure it’s necessary since other headers treat <sys/types.h> as always available, but I suppose it can’t hurt. So here is a revised patch as suggested.
>> 
>> 
>> Bootstrapped on x86_64-apple-darwin23. OK to push?
>> 
>> FX


[-- Attachment #2: 0001-jit-Ensure-ssize_t-is-defined.patch --]
[-- Type: application/octet-stream, Size: 958 bytes --]

From b06cdbb782514a37bb196770a8599f35bcbfc07e Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Sat, 11 May 2024 17:08:05 +0200
Subject: [PATCH] jit: Ensure ssize_t is defined

On some targets it seems that ssize_t is not defined by any of the
headers transitively included by <stdio.h>.  This leads to a bootstrap
fail when jit is enabled.

gcc/jit/ChangeLog:

	* libgccjit.h: Include <sys/types.h>
---
 gcc/jit/libgccjit.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gcc/jit/libgccjit.h b/gcc/jit/libgccjit.h
index 74e847b2dec..91184f973fd 100644
--- a/gcc/jit/libgccjit.h
+++ b/gcc/jit/libgccjit.h
@@ -21,6 +21,11 @@ along with GCC; see the file COPYING3.  If not see
 #define LIBGCCJIT_H
 
 #include <stdio.h>
+#ifdef __has_include
+#if __has_include (<sys/types.h>)
+#include <sys/types.h>
+#endif
+#endif
 
 #ifdef __cplusplus
 extern "C" {
-- 
2.39.3 (Apple Git-146)