From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106825 invoked by alias); 21 Nov 2017 15:30:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106793 invoked by uid 89); 21 Nov 2017 15:30:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail-ot0-f181.google.com Received: from mail-ot0-f181.google.com (HELO mail-ot0-f181.google.com) (74.125.82.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 15:30:38 +0000 Received: by mail-ot0-f181.google.com with SMTP id o23so10856431otd.1 for ; Tue, 21 Nov 2017 07:30:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=jWQl2A71zFzGBWFJZ/V6kqtqnHsIdNsh4H4Qta1INwA=; b=WMk7SXTkOjOIf6Z7mQb5KXdSksxOHKOS3xWmj75tgAU3nMJeCQKo5FQMittTl5ps6n lfr1PQBhKlgsVP9PLgqDgjf++9Nof7bjgRSqZbYmWOAEV1/yKVW+6Td4GmJI2KN3P5tZ iXjx6PTb46S2HEZ73AHVhX/+kGQs3QxXtWnciPaqPVVLMyynqaZGWe/DPq8zrgWYxu/x qvjXmFshdRhIeQ+UNUAF8nLxvLT9fZUNxuC+mM/8UPTp54yrlrP2hmpWEIvLaakTLPFp FPOVqpSXM21sytdI7uF+VzZPtVbh5L123Sl/30i8SW0FQLPBdxKTHI+7T4n36+7ZAhvB 75Pw== X-Gm-Message-State: AJaThX716nFDuMAkiAgv7vahrtk8UQnoCRK1q1qtk9l6Wf3Gpo8uUNZP JLjzYSdlXqmLviea0Ye16FD+6w== X-Google-Smtp-Source: AGs4zMbzKVkATTjHiteOhraLIkrOQR5262KaztPdLjduo9ATnzy+Jem28+HvAg5C2L0moXmNPIjQwg== X-Received: by 10.157.67.53 with SMTP id s50mr11281666ote.309.1511278235755; Tue, 21 Nov 2017 07:30:35 -0800 (PST) Received: from localhost.localdomain (75-171-240-43.hlrn.qwest.net. [75.171.240.43]) by smtp.gmail.com with ESMTPSA id f100sm3449090otf.3.2017.11.21.07.30.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Nov 2017 07:30:34 -0800 (PST) Subject: Re: [PATCH][RFC] Add quotes for constexpr keyword. To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , Jonathan Wakely References: <451b4f3d-d858-bbc8-5d1f-6056af5963d3@suse.cz> <20171018125252.GC19284@redhat.com> <99de094c-0e98-f2f2-39a9-a7394e0604ad@redhat.com> <0d484e7b-782b-7c4c-cdda-723efffe15a5@suse.cz> <7f78d1c7-ac2a-c43b-d0fb-9c09c70b65b2@gmail.com> <230260f8-2f1d-7f6d-973d-05ebe8ea78a4@gmail.com> <20171115163829.GG31922@redhat.com> <1b88d763-881f-749c-34b9-1ddfb67551eb@gmail.com> <20171115171029.GH31922@redhat.com> <991d8051-d6e4-5b3f-3944-8a0fdf3e7c9a@suse.cz> Cc: Jason Merrill , Marek Polacek , Jakub Jelinek , gcc-patches List From: Martin Sebor Message-ID: <482c7446-6023-f793-b98a-3b8143c61bb8@gmail.com> Date: Tue, 21 Nov 2017 15:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <991d8051-d6e4-5b3f-3944-8a0fdf3e7c9a@suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg01908.txt.bz2 On 11/21/2017 08:00 AM, Martin Liška wrote: > Hi. > > I'm sending v2 of the patch where I fixed test-suite fallout. > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. The changes look good to me. Thanks for the nice cleanup! Martin PS While going through the patch I noticed the -fconstexpr-depth= option also isn't quoted in a few instances. That would be nice to fix as well at some point (this can of course be done independently): if (!ctx->quiet) - error ("constexpr evaluation depth exceeds maximum of %d (use " + error ("% evaluation depth exceeds maximum of %d (use " "-fconstexpr-depth= to increase the maximum)", max_constexpr_depth);