From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14133 invoked by alias); 21 May 2008 15:05:04 -0000 Received: (qmail 14124 invoked by uid 22791); 21 May 2008 15:05:03 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 21 May 2008 15:04:45 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m4LF4hiB032092 for ; Wed, 21 May 2008 11:04:43 -0400 Received: from file.rdu.redhat.com (file.rdu.redhat.com [10.11.255.147]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m4LF4gVX023761; Wed, 21 May 2008 11:04:42 -0400 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by file.rdu.redhat.com (8.13.1/8.13.1) with ESMTP id m4LF4gYt026308; Wed, 21 May 2008 11:04:42 -0400 Message-ID: <48343A0A.10108@redhat.com> Date: Wed, 21 May 2008 15:51:00 -0000 From: Jason Merrill User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Jakub Jelinek CC: gcc-patches@gcc.gnu.org Subject: Re: Patch ping References: <20080507083202.GI2255@devserv.devel.redhat.com> <4821C23A.3040906@redhat.com> <20080521142831.GG29975@devserv.devel.redhat.com> In-Reply-To: <20080521142831.GG29975@devserv.devel.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-05/txt/msg01315.txt.bz2 Jakub Jelinek wrote: > I think this is uglification rather than cleanup, especially given the > size of the duplicated code and that the error messages need to be > different, but certainly if you prefer it that way, I can write a patch. I think I do prefer it that way, so that if we add additional checks in the future it will be obvious that we need to handle both cases. If checks are in two different places changes in one tend not to be reflected in the other. Jason