From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Add real_isdenormal.
Date: Sat, 3 Sep 2022 12:44:35 -0600 [thread overview]
Message-ID: <484b346a-8e6a-fd22-98d2-2319f5874027@gmail.com> (raw)
In-Reply-To: <20220903134827.3038778-1-aldyh@redhat.com>
On 9/3/2022 7:48 AM, Aldy Hernandez via Gcc-patches wrote:
> There are 6 idioms of the same check and I'd like to add more.
>
> It seems there are macros as well as functions for things like
> REAL_VALUE_ISINF and REAL_VALUE_NEGATIVE. I don't know if there was
> historical need for this duplicity, but I think it's cleaner if we
> start gravitating towards inline functions only.
>
> OK?
>
> gcc/ChangeLog:
>
> * real.cc (encode_ieee_single): Use real_isdenormal.
> (encode_ieee_double): Same.
> (encode_ieee_extended): Same.
> (encode_ieee_quad): Same.
> (encode_ieee_half): Same.
> (encode_arm_bfloat_half): Same.
> * real.h (real_isdenormal): New.
OK. And if there's any followups where you're doing similar kinds of
factoring of duplicated real.* code, consider such changes pre-approved.
jeff
prev parent reply other threads:[~2022-09-03 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 13:48 Aldy Hernandez
2022-09-03 18:44 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484b346a-8e6a-fd22-98d2-2319f5874027@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).