From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 1694A3858CDB for ; Sat, 3 Sep 2022 18:44:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1694A3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x431.google.com with SMTP id b144so199386pfb.7 for ; Sat, 03 Sep 2022 11:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=lbOvzRxva+erNCRQFAIBv/A9rjLDICGDe/kzgfOuOzQ=; b=j+t5aEOZFMOewOlQ78Qi7dcTVwgfdzcfrjXfUxPILOyQTlnkpA8C/jRc/ErR4IelvB uLpMgFsi+Jrx+CiT1lm3pNKZ3Vo+3x23UNud8V0qosQ/lPcUlooeuV4Tzu+mnr2gJt+N QTGUeFfvYAqaB38oyeIYjezWu/P8ELeFMPod9IVj9/kPFly42F4xdRq5uyZhMLZYpJQh QivtVReR3SYe6Kb26fKQBnpFUghsvTyWrsWSBAHb59qza/B86U9m+Nse+2s/u5P/zcFh M92piJYjNGMxnFKWNXLuzVAfTfFtkRvGEdAoPh3YPBUD0zRYnque0UJXPpLqgdY8Uf13 hz0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=lbOvzRxva+erNCRQFAIBv/A9rjLDICGDe/kzgfOuOzQ=; b=1phxPvsL5bZIwWpMTIjs4fiiQNaO+ez9GWDbDp5hm0o5Q4qir9y2OevSvXDgPt3QjH W3LxCDIp8Pp4pcWZSNNYvB4U1NcPC8jCR+9J7NytK9k+MG/Kg2su045LZ9c00ZLfKHVx 6na7zbGuK2QPrtQuFHyL6hUn4diNP5GHzixJ3VTA6FWQU0/Kq7aQKLhp2+12IgGeRwFm mUoKMcUMzcTtzE4kXG2rpJ3aJfZrnC7+ndfXMqeLGEQo49xBDgMYhIyJA2V7GHNPZIwk j8U8dg0YBpPd4/4LPIYdKsf94O+Y6nRxpje6b3DFugCyF26Ka0KrjJtCqsv9G7M7vVex PLMw== X-Gm-Message-State: ACgBeo3fEgaCQ2bqa1/IWhVgEiJqioKrrS5NLhk79eSOHlUnNttg5qLe ZPH61KQVBGrysO7JPMIQMNcWPFHK31DjVA== X-Google-Smtp-Source: AA6agR6FfVOaijEYDhPYlt0yD46bx5r0zV/pps4QsENqnZrlLbcUZlhVPIaLOSSMr3ZQeXqMkb3fEg== X-Received: by 2002:a05:6a00:1252:b0:53a:8943:4b1e with SMTP id u18-20020a056a00125200b0053a89434b1emr22365606pfi.2.1662230677415; Sat, 03 Sep 2022 11:44:37 -0700 (PDT) Received: from [172.31.0.204] (c-73-98-188-51.hsd1.ut.comcast.net. [73.98.188.51]) by smtp.gmail.com with ESMTPSA id l68-20020a622547000000b00538505ff705sm4364885pfl.91.2022.09.03.11.44.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Sep 2022 11:44:36 -0700 (PDT) Message-ID: <484b346a-8e6a-fd22-98d2-2319f5874027@gmail.com> Date: Sat, 3 Sep 2022 12:44:35 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] Add real_isdenormal. Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220903134827.3038778-1-aldyh@redhat.com> From: Jeff Law In-Reply-To: <20220903134827.3038778-1-aldyh@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/3/2022 7:48 AM, Aldy Hernandez via Gcc-patches wrote: > There are 6 idioms of the same check and I'd like to add more. > > It seems there are macros as well as functions for things like > REAL_VALUE_ISINF and REAL_VALUE_NEGATIVE. I don't know if there was > historical need for this duplicity, but I think it's cleaner if we > start gravitating towards inline functions only. > > OK? > > gcc/ChangeLog: > > * real.cc (encode_ieee_single): Use real_isdenormal. > (encode_ieee_double): Same. > (encode_ieee_extended): Same. > (encode_ieee_quad): Same. > (encode_ieee_half): Same. > (encode_arm_bfloat_half): Same. > * real.h (real_isdenormal): New. OK.  And if there's any followups where you're doing similar kinds of factoring of duplicated real.* code, consider such changes pre-approved. jeff